From: Veaceslav Falico <vfalico@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next] bridge: remove a redundant synchronize_net()
Date: Tue, 2 Apr 2013 17:58:22 +0200 [thread overview]
Message-ID: <20130402155822.GB29115@redhat.com> (raw)
In-Reply-To: <1364917500.5113.176.camel@edumazet-glaptop>
On Tue, Apr 02, 2013 at 08:45:00AM -0700, Eric Dumazet wrote:
>From: Eric Dumazet <edumazet@google.com>
>
>commit 00cfec37484761 (net: add a synchronize_net() in
>netdev_rx_handler_unregister())
>allows us to remove the synchronized_net() call from del_nbp()
>
>Signed-off-by: Eric Dumazet <edumazet@google.com>
>Cc: Veaceslav Falico <vfalico@redhat.com>
>Cc: Stephen Hemminger <stephen@networkplumber.org>
>---
> net/bridge/br_if.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
>index ef1b914..f17fcb3 100644
>--- a/net/bridge/br_if.c
>+++ b/net/bridge/br_if.c
>@@ -148,7 +148,6 @@ static void del_nbp(struct net_bridge_port *p)
> dev->priv_flags &= ~IFF_BRIDGE_PORT;
>
> netdev_rx_handler_unregister(dev);
>- synchronize_net();
>
> netdev_upper_dev_unlink(dev, br->dev);
>
>
>
Thanks, didn't see that when fixing bonding.
Acked-by: Veaceslav Falico <vfalico@redhat.com>
next prev parent reply other threads:[~2013-04-02 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 15:45 [PATCH net-next] bridge: remove a redundant synchronize_net() Eric Dumazet
2013-04-02 15:58 ` Veaceslav Falico [this message]
2013-04-02 16:12 ` David Miller
2013-04-02 16:27 ` Eric Dumazet
2013-04-02 18:19 ` David Miller
2013-04-04 15:35 ` Jiri Pirko
2013-04-04 15:44 ` Eric Dumazet
2013-04-04 16:03 ` Eric Dumazet
2013-04-04 16:08 ` Jiri Pirko
2013-04-04 16:07 ` Jiri Pirko
2013-04-04 16:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402155822.GB29115@redhat.com \
--to=vfalico@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).