From: Thomas Graf <tgraf@suug.ch>
To: Jesse Gross <jesse@nicira.com>
Cc: "dev@openvswitch.org" <dev@openvswitch.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages
Date: Wed, 3 Apr 2013 08:33:56 +0100 [thread overview]
Message-ID: <20130403073356.GA6402@casper.infradead.org> (raw)
In-Reply-To: <CAEP_g=_5+1ZjiXEMCTSXE2Rt6HNkfFx1uR3KNCzwitJrLQYesg@mail.gmail.com>
On 04/02/13 at 04:30pm, Jesse Gross wrote:
> Can you describe the race condition some more? The kernel doesn't
> change the port ID on its own so even needing to request the value
> seems rare.
The upcall nlport is changeable with OVS_VPORT_CMD_SET and may
be received between the OVS_DP_CMD_GET and OVS_VPORT_CMD_GET.
> Assigning the local ports upcall PID through datapath creation is
> really somewhat of a hack since it's port state. I don't disagree
> that it's somewhat asymmetric now but it seems better to move away
> from the current model if possible.
Would you suggest to wait with local vport creation if no upcall
nlport is provided and let new user space binaries create the local
port explicitly?
We can't get rid of the attribute in datapath messages w/o breaking
ABI but we could make its use optional I guess.
next prev parent reply other threads:[~2013-04-03 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 22:28 [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages Thomas Graf
2013-04-02 23:30 ` Jesse Gross
2013-04-03 7:33 ` Thomas Graf [this message]
2013-04-03 20:17 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130403073356.GA6402@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=dev@openvswitch.org \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).