From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: hayeswang@realtek.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bowgotsai@google.com
Subject: Re: [PATCH v2] r8169: fix auto speed down issue
Date: Thu, 04 Apr 2013 17:46:33 -0400 (EDT) [thread overview]
Message-ID: <20130404.174633.55409356599454602.davem@davemloft.net> (raw)
In-Reply-To: <20130402213736.GA15328@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Tue, 2 Apr 2013 23:37:36 +0200
> Hayes Wang <hayeswang@realtek.com> :
>> It would cause no link after suspending or shutdowning when the
>> nic changes the speed to 10M and connects to a link partner which
>> forces the speed to 100M.
>>
>> Check the link partner ability to determine which speed to set.
>>
>> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Applied.
>> +static void rtl_speed_down(struct rtl8169_private *tp)
>> +{
>> + u32 adv;
>> + int lpa;
> ^^^^^
> Please use a single, true space (no tabs) next time.
I fixed this up when I applied this patch, thanks.
prev parent reply other threads:[~2013-04-04 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 7:11 [PATCH] r8169: fix auto speed down issue Hayes Wang
2013-03-30 12:43 ` Francois Romieu
2013-04-01 3:02 ` [PATCH v2] " Hayes Wang
2013-04-02 21:37 ` Francois Romieu
2013-04-04 21:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404.174633.55409356599454602.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bowgotsai@google.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).