From: Werner Almesberger <werner@almesberger.net>
To: Sascha Herrmann <sascha@ps.nvbi.de>
Cc: netdev@vger.kernel.org, linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq
Date: Fri, 5 Apr 2013 07:51:58 -0300 [thread overview]
Message-ID: <20130405105158.GD29789@ws> (raw)
In-Reply-To: <20130405035949.GC29789@ws>
I wrote:
> To achieve perfection, at86rf230_probe could try all four
> possible trigger modes, pick one the platform supports, and
> set TRX_CTRL_1.IRQ_POLARITY accordingly.
Thinking of it, probing by trying request_irq has an unpleasant ring
to it. Perhaps a better way would be to leave this decision to the
platform code and do one of these:
1) pass irqflags and the polarity in the platform data, or
2) pass irqflags and extract the polarity from the irqflags, or
3) set up the trigger mode outside the driver and pass only the
polarity,
where 1) with (irqflags & IRQF_TRIGGER_MASK) == 0 includes
case 3).
- Werner
next prev parent reply other threads:[~2013-04-05 10:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 21:01 [PATCH 0/2] changed irq handling and some cleanup for at86rf230 Sascha Herrmann
2013-04-04 21:02 ` [PATCH 1/2] at86rf230: remove unnecessary / dead code Sascha Herrmann
2013-04-08 16:01 ` David Miller
2013-04-04 21:02 ` [PATCH 2/2] at86rf230: change irq handling to prevent lockups with edge type irq Sascha Herrmann
[not found] ` <57c67195742f5e7482dc57f5a05b6d69156b00d2.1365107512.git.sascha-2k69yqSu1NaELgA04lAiVw@public.gmane.org>
2013-04-05 3:59 ` Werner Almesberger
2013-04-05 10:51 ` Werner Almesberger [this message]
2013-04-05 15:59 ` [Linux-zigbee-devel] " Sascha Herrmann
2013-04-06 14:20 ` Werner Almesberger
2013-04-07 20:52 ` Sascha Herrmann
2013-04-08 15:35 ` Werner Almesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130405105158.GD29789@ws \
--to=werner@almesberger.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=sascha@ps.nvbi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).