From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: olaf@aepfle.de, netdev@vger.kernel.org, jasowang@redhat.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH net,1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback()
Date: Mon, 08 Apr 2013 12:16:14 -0400 (EDT) [thread overview]
Message-ID: <20130408.121614.2170605259377916404.davem@davemloft.net> (raw)
In-Reply-To: <1365198280-23270-1-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri, 5 Apr 2013 14:44:39 -0700
> The warning about local_bh_enable inside IRQ happens when disconnecting a
> virtual NIC.
>
> The reason for the warning is -- netif_tx_disable() is called when the NIC
> is disconnected. And it's called within irq context. netif_tx_disable() calls
> local_bh_enable() which displays warning if in irq.
>
> The fix is to remove the unnecessary netif_tx_disable & wake_queue() in the
> netvsc_linkstatus_callback().
>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Tested-by: Long Li <longli@microsoft.com>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied.
next prev parent reply other threads:[~2013-04-08 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 21:44 [PATCH net,1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback() Haiyang Zhang
2013-04-05 21:44 ` [PATCH net,2/2] hyperv: Fix RNDIS send_completion code path Haiyang Zhang
2013-04-08 16:16 ` David Miller
2013-04-08 16:16 ` David Miller [this message]
2013-05-23 8:44 ` [PATCH net, 1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback() Richard Genoud
2013-05-23 13:14 ` Kernel v3.2 used in SlackWare 14.00 please, backport all needed patches " Victor Miasnikov
2013-05-28 3:10 ` Ben Hutchings
2013-05-23 14:51 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408.121614.2170605259377916404.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).