netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: netdev@vger.kernel.org
Cc: Miroslav Vadkerti <mvadkert@redhat.com>
Subject: [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet
Date: Mon, 08 Apr 2013 11:45:19 -0400	[thread overview]
Message-ID: <20130408154519.18177.57709.stgit@localhost> (raw)

Commit 90ba9b1986b5ac4b2d184575847147ea7c4280a2 converted
tcp_make_synack() to use alloc_skb() directly instead of calling
sock_wmalloc(), the goal being the elimination of two atomic
operations.  Unfortunately, in doing so the change broke certain
SELinux/NetLabel configurations by no longer correctly assigning
the sock to the outgoing packet.

This patch fixes this regression by doing the skb->sk assignment
directly inside tcp_make_synack().

Reported-by: Miroslav Vadkerti <mvadkert@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
---
 net/ipv4/tcp_output.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 5d0b438..23cc295 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2705,6 +2705,8 @@ struct sk_buff *tcp_make_synack(struct sock *sk, struct dst_entry *dst,
 		dst_release(dst);
 		return NULL;
 	}
+	skb->sk = sk;
+
 	/* Reserve space for headers. */
 	skb_reserve(skb, MAX_TCP_HEADER);
 

             reply	other threads:[~2013-04-08 15:45 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 15:45 Paul Moore [this message]
2013-04-08 16:14 ` [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet David Miller
2013-04-08 17:22   ` Paul Moore
2013-04-08 17:36     ` Eric Dumazet
2013-04-08 17:40       ` Paul Moore
2013-04-08 17:47         ` Eric Dumazet
2013-04-08 18:01           ` Eric Dumazet
2013-04-08 18:12           ` Paul Moore
2013-04-08 18:21             ` Eric Dumazet
2013-04-08 18:26               ` Paul Moore
2013-04-08 18:34                 ` Eric Dumazet
2013-04-08 18:30               ` Eric Dumazet
2013-04-08 20:37                 ` Paul Moore
2013-04-08 20:44                   ` David Miller
2013-04-08 20:53                     ` Paul Moore
2013-04-08 20:55                   ` Eric Dumazet
2013-04-08 21:09                     ` Paul Moore
2013-04-08 21:14                       ` David Miller
2013-04-08 21:17                       ` Eric Dumazet
2013-04-09  3:58                       ` [PATCH] selinux: add a skb_owned_by() hook Eric Dumazet
2013-04-09  4:29                         ` Casey Schaufler
2013-04-09  4:41                           ` David Miller
2013-04-09  5:14                             ` Casey Schaufler
2013-04-09 11:39                             ` Paul Moore
2013-04-09  6:24                           ` Eric Dumazet
2013-04-09 11:45                           ` Paul Moore
2013-04-09  7:38                         ` James Morris
2013-04-09 12:06                         ` Paul Moore
2013-04-09 17:23                         ` David Miller
2013-04-08 18:32             ` [PATCH] tcp: assign the sock correctly to an outgoing SYNACK packet Paul Moore
2013-04-08 21:10               ` Paul Moore
2013-04-08 21:15                 ` David Miller
2013-04-08 21:24                   ` Paul Moore
2013-04-08 21:33                     ` David Miller
2013-04-08 22:01                       ` Paul Moore
2013-04-08 22:08                         ` David Miller
2013-04-08 23:40                       ` Casey Schaufler
2013-04-09  0:33                         ` Eric Dumazet
2013-04-09  0:59                           ` Casey Schaufler
2013-04-09  1:09                             ` Eric Dumazet
2013-04-09  1:24                               ` Casey Schaufler
2013-04-09 13:19                                 ` Paul Moore
2013-04-09 13:33                                   ` Paul Moore
2013-04-09 14:00                                   ` Eric Dumazet
2013-04-09 14:19                                     ` Paul Moore
2013-04-09 14:31                                       ` Eric Dumazet
2013-04-09 14:52                                         ` Paul Moore
2013-04-09 15:05                                           ` Paul Moore
2013-04-09 15:07                                           ` Eric Dumazet
2013-04-09 15:17                                             ` Paul Moore
2013-04-09 15:32                                               ` Eric Dumazet
2013-04-09 15:57                                                 ` Paul Moore
2013-04-09 16:11                                                 ` Casey Schaufler
2013-04-09 16:56                                                 ` David Miller
2013-04-09 17:00                                                   ` Paul Moore
2013-04-09 17:09                                                     ` David Miller
2013-04-09 17:10                                                       ` David Miller
2013-04-09 14:05                                   ` Ben Hutchings
2013-04-09 14:10                                     ` Paul Moore
2013-04-08 21:34                     ` Ben Hutchings
2013-04-08 19:25     ` David Miller
2013-04-08 16:19 ` Eric Dumazet
2013-04-08 18:03 ` Sergei Shtylyov
2013-04-08 18:12   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408154519.18177.57709.stgit@localhost \
    --to=pmoore@redhat.com \
    --cc=mvadkert@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).