From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: ralf@linux-mips.org, minipli@googlemail.com, davem@davemloft.net,
yongjun_wei@trendmicro.com.cn, linux-hams@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH -next] netrom: fix invalid use of sizeof in nr_recvmsg()
Date: Tue, 9 Apr 2013 05:09:05 +0200 [thread overview]
Message-ID: <20130409030905.GA2527@order.stressinduktion.org> (raw)
In-Reply-To: <CAPgLHd-yEmt_BJ52uZNsCA_-w85VhnN_HbfjG1QLVvR5kp7Xvw@mail.gmail.com>
On Tue, Apr 09, 2013 at 10:07:19AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> sizeof() when applied to a pointer typed expression gives the size of the
> pointer, not that of the pointed data.
> Introduced by commit 3ce5ef(netrom: fix info leak via msg_name in nr_recvmsg)
I think it would be a good idea to enable -Wsizeof-pointer-memaccess
(gcc 4.8 feature) by default. While enabled there were no additional
warnings when I tested it some weeks ago. I will look into this.
next prev parent reply other threads:[~2013-04-09 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 2:07 [PATCH -next] netrom: fix invalid use of sizeof in nr_recvmsg() Wei Yongjun
2013-04-09 2:49 ` David Miller
2013-04-09 3:05 ` Wei Yongjun
2013-04-09 3:09 ` Hannes Frederic Sowa [this message]
2013-04-09 5:49 ` Mathias Krause
-- strict thread matches above, loose matches on Subject: below --
2013-04-21 17:56 f6bvp@free
2013-04-21 18:00 ` Mathias Krause
[not found] <51742437.6080406@free.fr>
2013-04-21 18:05 ` f6bvp@free
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409030905.GA2527@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=linux-hams@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox