From: Willy Tarreau <w@1wt.eu>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: mvneta: enable features before registering the driver
Date: Tue, 9 Apr 2013 07:46:00 +0200 [thread overview]
Message-ID: <20130409054600.GA31821@1wt.eu> (raw)
In-Reply-To: <20130408.121604.421731991206410747.davem@davemloft.net>
On Mon, Apr 08, 2013 at 12:16:04PM -0400, David Miller wrote:
> From: Willy Tarreau <w@1wt.eu>
> Date: Sat, 6 Apr 2013 20:47:01 +0200
>
> > Hi,
> >
> > I noticed that mvneta's tx-csum/sg were off until disabled then
> > enabled, which led me to think that something was not made in the
> > correct sequence. And indeed, setting the dev features _before_
> > registering the device works much better :-)
> >
> > This patch is for master but may be backported to 3.8-stable as well,
> > which is where I first experienced the issue.
>
> Please don't post patches like this, you make extra work for the
> maintainer by having to edit out this commentary.
>
> You put such commentary after the "---" seperator the delineates
> your commit message in the email body, not before.
Sorry for this David, I'll take care of this next time.
> Anyways, applied.
Thank you.
Willy
prev parent reply other threads:[~2013-04-09 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:47 [PATCH] net: mvneta: enable features before registering the driver Willy Tarreau
2013-04-07 10:11 ` Thomas Petazzoni
2013-04-08 16:16 ` David Miller
2013-04-09 5:46 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409054600.GA31821@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).