Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yuvalmin@broadcom.com
Cc: netdev@vger.kernel.org, ariele@broadcom.com, eilong@broadcom.com
Subject: Re: [PATCH net] bnx2x: Prevent null pointer dereference in AFEX mode
Date: Wed, 10 Apr 2013 15:27:29 -0400 (EDT)	[thread overview]
Message-ID: <20130410.152729.217349451145514475.davem@davemloft.net> (raw)
In-Reply-To: <1365590079-7422-1-git-send-email-yuvalmin@broadcom.com>

From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Wed, 10 Apr 2013 13:34:39 +0300

> The cnic module is responsible for initializing various bnx2x structs
> via callbacks provided by the bnx2x module.
> One such struct is the queue object for the FCoE queue.
> 
> If a device is working in AFEX mode and its configuration allows FCoE yet 
> the cnic module is not loaded, it's very likely a null pointer dereference
> will occur, as the bnx2x will erroneously access the FCoE's queue object.
> 
> Prevent said access until cnic properly registers itself.
> 
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>

Applied, thanks.

      reply	other threads:[~2013-04-10 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 10:34 [PATCH net] bnx2x: Prevent null pointer dereference in AFEX mode Yuval Mintz
2013-04-10 19:27 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130410.152729.217349451145514475.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ariele@broadcom.com \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=yuvalmin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox