From: Stephen Hemminger <stephen@networkplumber.org>
To: Atzm Watanabe <atzm@stratosphere.co.jp>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] vxlan: Allow setting unicast address to the group address
Date: Wed, 10 Apr 2013 09:46:39 -0700 [thread overview]
Message-ID: <20130410094639.748d022f@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <87sj2yn4y2.wl%atzm@stratosphere.co.jp>
On Wed, 10 Apr 2013 17:52:05 +0900
Atzm Watanabe <atzm@stratosphere.co.jp> wrote:
> This patch allows setting unicast address to the VXLAN group address.
> It allows that VXLAN can be used as peer-to-peer tunnel without
> multicast.
>
> Signed-off-by: Atzm Watanabe <atzm@stratosphere.co.jp>
> ---
> ip/iplink_vxlan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> index 1025326..cfe324c 100644
> --- a/ip/iplink_vxlan.c
> +++ b/ip/iplink_vxlan.c
> @@ -66,9 +66,6 @@ static int vxlan_parse_opt(struct link_util *lu, int argc, char **argv,
> } else if (!matches(*argv, "group")) {
> NEXT_ARG();
> gaddr = get_addr32(*argv);
> -
> - if (!IN_MULTICAST(ntohl(gaddr)))
> - invarg("invald group address", *argv);
> } else if (!matches(*argv, "local")) {
> NEXT_ARG();
> if (strcmp(*argv, "any"))
Could you use another name or argument to express the different intended behavior.
next prev parent reply other threads:[~2013-04-10 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 8:52 [PATCH iproute2] vxlan: Allow setting unicast address to the group address Atzm Watanabe
2013-04-10 16:46 ` Stephen Hemminger [this message]
2013-04-11 6:27 ` Atzm Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410094639.748d022f@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=atzm@stratosphere.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox