From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, ycheng@google.com,
nanditad@google.com, ncardwell@google.com
Subject: Re: [PATCH net-next] tcp: GSO should be TSQ friendly
Date: Fri, 12 Apr 2013 18:17:49 -0400 (EDT) [thread overview]
Message-ID: <20130412.181749.137416591880112218.davem@davemloft.net> (raw)
In-Reply-To: <1365802312.4459.82.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Apr 2013 14:31:52 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> I noticed that TSQ (TCP Small queues) was less effective when TSO is
> turned off, and GSO is on. If BQL is not enabled, TSQ has then no
> effect.
>
> It turns out the GSO engine frees the original gso_skb at the time the
> fragments are generated and queued to the NIC.
>
> We should instead call the tcp_wfree() destructor for the last fragment,
> to keep the flow control as intended in TSQ. This effectively limits
> the number of queued packets on qdisc + NIC layers.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Looks good to me, applied, thanks!
prev parent reply other threads:[~2013-04-12 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 21:31 [PATCH net-next] tcp: GSO should be TSQ friendly Eric Dumazet
2013-04-12 22:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130412.181749.137416591880112218.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).