netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: thomas.petazzoni@free-electrons.com
Cc: netdev@vger.kernel.org, andrew@lunn.ch, jason@lakedaemon.net,
	maen@marvell.com, alior@marvell.com,
	gregory.clement@free-electrons.com,
	ezequiel.garcia@free-electrons.com, florian@openwrt.org
Subject: Re: [PATCH] net: mvmdio: add select PHYLIB
Date: Sat, 13 Apr 2013 16:48:34 -0400 (EDT)	[thread overview]
Message-ID: <20130413.164834.1146247422887398317.davem@davemloft.net> (raw)
In-Reply-To: <1365869936-17190-1-git-send-email-thomas.petazzoni@free-electrons.com>

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sat, 13 Apr 2013 18:18:56 +0200

> The mvmdio driver uses the phylib API, so it should select the PHYLIB
> symbol, otherwise, a build with mvmdio (but without mvneta) fails to
> build with undefined symbols such as mdiobus_unregister, mdiobus_free,
> etc.
> 
> The mvneta driver does not use the phylib API directly, so it does not
> need to select PHYLIB. It already selects the mvmdio driver anyway.
> 
> Historically, this problem is due to the fact that the PHY handling
> was originally part of mvneta, and was later moved to a separate
> driver, without updating the Kconfig select statements
> accordingly. And since there was no functional reason to use mvmdio
> without mvneta, this case was not tested.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2013-04-13 20:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 16:18 [PATCH] net: mvmdio: add select PHYLIB Thomas Petazzoni
2013-04-13 20:48 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130413.164834.1146247422887398317.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=florian@openwrt.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=maen@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).