* [PATCH net-next] net: tcp_memcontrol: minor: remove unused variable
[not found] <cover.1365963999.git.dborkman@redhat.com>
@ 2013-04-14 18:29 ` Daniel Borkmann
2013-04-14 19:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2013-04-14 18:29 UTC (permalink / raw)
To: davem; +Cc: netdev
Commit 10b96f7306e5 (``tcp_memcontrol: remove a redundant statement
in tcp_destroy_cgroup()'') says ``We read the value but make no use
of it.'', but forgot to remove the variable declaration as well. This
was a follow-up commit of 3f1346193 (``memcg: decrement static keys
at real destroy time'') that removed the read of variable 'val'.
This fixes therefore:
CC net/ipv4/tcp_memcontrol.o
net/ipv4/tcp_memcontrol.c: In function ‘tcp_destroy_cgroup’:
net/ipv4/tcp_memcontrol.c:67:6: warning: unused variable ‘val’ [-Wunused-variable]
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
net/ipv4/tcp_memcontrol.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/ipv4/tcp_memcontrol.c b/net/ipv4/tcp_memcontrol.c
index d52196f..da14436 100644
--- a/net/ipv4/tcp_memcontrol.c
+++ b/net/ipv4/tcp_memcontrol.c
@@ -64,7 +64,6 @@ void tcp_destroy_cgroup(struct mem_cgroup *memcg)
{
struct cg_proto *cg_proto;
struct tcp_memcontrol *tcp;
- u64 val;
cg_proto = tcp_prot.proto_cgroup(memcg);
if (!cg_proto)
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: tcp_memcontrol: minor: remove unused variable
2013-04-14 18:29 ` [PATCH net-next] net: tcp_memcontrol: minor: remove unused variable Daniel Borkmann
@ 2013-04-14 19:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-04-14 19:43 UTC (permalink / raw)
To: dborkman; +Cc: netdev
From: Daniel Borkmann <dborkman@redhat.com>
Date: Sun, 14 Apr 2013 20:29:12 +0200
> Commit 10b96f7306e5 (``tcp_memcontrol: remove a redundant statement
> in tcp_destroy_cgroup()'') says ``We read the value but make no use
> of it.'', but forgot to remove the variable declaration as well. This
> was a follow-up commit of 3f1346193 (``memcg: decrement static keys
> at real destroy time'') that removed the read of variable 'val'.
>
> This fixes therefore:
>
> CC net/ipv4/tcp_memcontrol.o
> net/ipv4/tcp_memcontrol.c: In function ‘tcp_destroy_cgroup’:
> net/ipv4/tcp_memcontrol.c:67:6: warning: unused variable ‘val’ [-Wunused-variable]
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-14 19:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1365963999.git.dborkman@redhat.com>
2013-04-14 18:29 ` [PATCH net-next] net: tcp_memcontrol: minor: remove unused variable Daniel Borkmann
2013-04-14 19:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).