From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
jasowang@redhat.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org
Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send()
Date: Tue, 16 Apr 2013 15:49:12 -0400 (EDT) [thread overview]
Message-ID: <20130416.154912.896506198616355113.davem@davemloft.net> (raw)
In-Reply-To: <57e8f99081a94575a57cae5e93705c22@DFM-DB3MBX15-06.exchange.corp.microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Tue, 16 Apr 2013 19:34:52 +0000
> The Hyper-V hosts always use 64 bit request id. The guests can have
> 32 or 64 bit pointers which equal to the ulong type size. So we cast
> it to ulong type. And, assigning 32bit integer to 64 bit variable
> works fine.
It works fine, but it's unclean.
Keep the req_id type as "u64", because that's what it is, a 64-bit request ID.
next prev parent reply other threads:[~2013-04-16 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 19:03 [PATCH net] hyperv: Fix a compiler warning in netvsc_send() Haiyang Zhang
2013-04-16 19:11 ` David Miller
2013-04-16 19:34 ` Haiyang Zhang
2013-04-16 19:49 ` David Miller [this message]
2013-04-16 20:18 ` Haiyang Zhang
2013-04-16 20:31 ` Joe Perches
2013-04-16 20:45 ` Haiyang Zhang
-- strict thread matches above, loose matches on Subject: below --
2013-04-16 22:25 Haiyang Zhang
2013-04-19 20:50 ` David Miller
2013-04-19 20:57 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416.154912.896506198616355113.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox