From: David Miller <davem@davemloft.net>
To: lars@metafoo.de
Cc: fabio.estevam@freescale.com, netdev@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH 5/5] ks8851: Remove unneeded PM_OPS definitions
Date: Tue, 16 Apr 2013 16:37:50 -0400 (EDT) [thread overview]
Message-ID: <20130416.163750.1652843849557504513.davem@davemloft.net> (raw)
In-Reply-To: <516DB4B1.9050602@metafoo.de>
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Tue, 16 Apr 2013 22:29:37 +0200
> On 04/16/2013 09:28 PM, Fabio Estevam wrote:
>> SIMPLE_DEV_PM_OPS macro can handle !CONFIG_PM_SLEEP case nicely, so there is no
>> need to define PM_OPS for both CONFIG_PM_SLEEP and !CONFIG_PM_SLEEP cases.
>>
>> Remove the unneeded definitions.
>>
>> Cc: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> yea, but now you have the dev_pm_ops struct, even if pm is disabled.
That's fine, it allows the functions to be compile tested in all
configurations.
next prev parent reply other threads:[~2013-04-16 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 19:28 [PATCH 1/5] can: mcp251x: Remove unneeded PM_OPS definitions Fabio Estevam
2013-04-16 19:28 ` [PATCH 2/5] atl1: " Fabio Estevam
2013-04-16 19:28 ` [PATCH 3/5] tg3: " Fabio Estevam
2013-04-16 19:28 ` [PATCH 4/5] xgmac: " Fabio Estevam
2013-04-16 19:28 ` [PATCH 5/5] ks8851: " Fabio Estevam
2013-04-16 20:29 ` Lars-Peter Clausen
2013-04-16 20:37 ` David Miller [this message]
2013-04-17 6:27 ` Lars-Peter Clausen
2013-04-16 19:42 ` [PATCH 1/5] can: mcp251x: " Marc Kleine-Budde
2013-04-16 19:49 ` David Miller
2013-04-16 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416.163750.1652843849557504513.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=joe@perches.com \
--cc=lars@metafoo.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).