* [PATCH net-next] tlan: cancel work at remove path
@ 2013-04-16 11:30 Devendra Naga
2013-04-16 20:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Naga @ 2013-04-16 11:30 UTC (permalink / raw)
To: Samuel Chessman, David S. Miller, netdev
Cc: Devendra Naga, Sriram, Cyril Chemparathy, Vinay Hegde
the work has been scheduled from interrupt, and not been
cancelled when the driver is unloaded, which doesn't remove
the work item from the global workqueue. call the
cancel_work_sync when the driver is removed (rmmod'ed).
Cc: Sriram <srk@ti.com>
Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Vinay Hegde <vinay.hegde@ti.com>
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
Hi,
This is only compile tested and not tested
on the the NIC which i dont have.
thanks
drivers/net/ethernet/ti/tlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index bdda36f..60c400f 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)
free_netdev(dev);
pci_set_drvdata(pdev, NULL);
+ cancel_work_sync(&priv->tlan_tqueue);
}
static void tlan_start(struct net_device *dev)
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tlan: cancel work at remove path
2013-04-16 11:30 [PATCH net-next] tlan: cancel work at remove path Devendra Naga
@ 2013-04-16 20:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-04-16 20:40 UTC (permalink / raw)
To: devendra.aaru; +Cc: chessman, netdev, srk, cyril, vinay.hegde
From: Devendra Naga <devendra.aaru@gmail.com>
Date: Tue, 16 Apr 2013 17:00:38 +0530
> the work has been scheduled from interrupt, and not been
> cancelled when the driver is unloaded, which doesn't remove
> the work item from the global workqueue. call the
> cancel_work_sync when the driver is removed (rmmod'ed).
>
> Cc: Sriram <srk@ti.com>
> Cc: Cyril Chemparathy <cyril@ti.com>
> Cc: Vinay Hegde <vinay.hegde@ti.com>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-16 20:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-16 11:30 [PATCH net-next] tlan: cancel work at remove path Devendra Naga
2013-04-16 20:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).