From: David Miller <davem@davemloft.net>
To: n1ght.4nd.d4y@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPv6: simplify & condense a few declarations & statements
Date: Wed, 17 Apr 2013 13:28:18 -0400 (EDT) [thread overview]
Message-ID: <20130417.132818.1433580618679802344.davem@davemloft.net> (raw)
In-Reply-To: <1366219222.3504.8.camel@lizardlounge>
From: Nathaniel Yazdani <n1ght.4nd.d4y@gmail.com>
Date: Wed, 17 Apr 2013 10:20:22 -0700
> This patch combines several statements/declarations into more concise forms and removes a
> couple of unnecessary local variables within a few functions, mostly inline.
Please make commit messages with 80 column long lines maximum.
> @@ -111,10 +111,7 @@ static inline void fib6_walker_unlink(struct fib6_walker_t *w)
> }
> static __inline__ u32 fib6_new_sernum(void)
> {
> - u32 n = ++rt_sernum;
> - if ((__s32)n <= 0)
> - rt_sernum = n = 1;
> - return n;
> + return (__s32)++rt_sernum <= 0 ? rt_sernum = 1 : rt_sernum;
Like your commit message, I find this unreadable, and definitely not
an improvement.
I'm not applying this even with the long lines in the commit message
fixes, sorry.
next prev parent reply other threads:[~2013-04-17 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 17:20 [PATCH] IPv6: simplify & condense a few declarations & statements Nathaniel Yazdani
2013-04-17 17:28 ` David Miller [this message]
2013-04-17 18:02 ` Nathaniel Yazdani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417.132818.1433580618679802344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=n1ght.4nd.d4y@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).