From: Dave Jones <davej@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: oops in udpv6_sendmsg
Date: Wed, 17 Apr 2013 10:11:38 -0400 [thread overview]
Message-ID: <20130417141138.GA17648@redhat.com> (raw)
In-Reply-To: <1366164132.3205.21.camel@edumazet-glaptop>
On Tue, Apr 16, 2013 at 07:02:12PM -0700, Eric Dumazet wrote:
> > rax is all kinds of crazy. 7ae9fffffff2b8ff doesn't look anything like an address.
>
> rt->rt6i_idev contains garbage. It looks like a dst refcount issue.
>
> Wow, it seems ip6_append_data() calls sock_alloc_send_skb() and can
> release socket lock while waiting for buffer space.
>
> This completely defeats corking, as another thread can mess with
> cork->dst at the same time.
>
> We need to hold dst before sleeping in sock_alloc_send_skb()
good news is that with some changes, I was able to make current
trinity reproduce this in seconds rather than hours..
./trinity -q -l off -n -c sendmsg -c connect
on current tree seems to reliably trigger it for me.
Dave
next prev parent reply other threads:[~2013-04-17 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 18:40 oops in udpv6_sendmsg Dave Jones
2013-03-29 18:49 ` Eric Dumazet
2013-04-02 1:23 ` Eric Dumazet
2013-04-11 0:29 ` Dave Jones
2013-04-17 1:02 ` Dave Jones
2013-04-17 2:02 ` Eric Dumazet
2013-04-17 14:11 ` Dave Jones [this message]
2013-04-17 14:27 ` Eric Dumazet
2013-04-17 16:05 ` Eric Dumazet
2013-06-25 21:28 ` Hannes Frederic Sowa
2013-06-26 9:22 ` Eric Dumazet
2013-06-26 9:29 ` Eric Dumazet
2013-06-26 11:15 ` Eric Dumazet
2013-06-26 13:07 ` Hannes Frederic Sowa
2013-06-26 22:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417141138.GA17648@redhat.com \
--to=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).