Re: [PATCH v3 net-next] bond: add support to read speed and duplex via ethtool

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 17 Apr 2013 16:34:26 +0100

> On Tue, 2013-04-16 at 20:46 -0400, Andy Gospodarek wrote:
>> This patch adds support for the get_settings ethtool op to the bonding
>> driver.  This was motivated by users who wanted to get the speed of the
>> bond and compare that against throughput to understand utilization.
>> The behavior before this patch was added was problematic when computing
>> line utilization after trying to get link-speed and throughput via SNMP.
>> 
>> Output from ethtool looks like this for a round-robin bond:
>> 
>> Settings for bond0:
>> 	Supported ports: [ ]
>> 	Supported link modes:   Not reported
>> 	Supported pause frame use: No
>> 	Supports auto-negotiation: No
>> 	Advertised link modes:  Not reported
>> 	Advertised pause frame use: No
>> 	Advertised auto-negotiation: No
>> 	Speed: 11000Mb/s
>> 	Duplex: Full
>> 	Port: Other
>> 	PHYAD: 0
>> 	Transceiver: internal
>> 	Auto-negotiation: off
>> 	MDI-X: Unknown
>> 	Link detected: yes
>> 
>> I tested this and verified it works as expected.  A test was also done
>> on a version backported to an older kernel and it worked well there.
>> 
>> v2: Switch to using ethtool_cmd_speed_set to set speed, added check to
>> SLAVE_IS_OK for each slave in bond, dropped mode-specific calculations
>> as they were not needed, and set port type to 'Other.'
>> 
>> v3: Fix useless assignment and checkpatch warning.
>> 
>> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> 
> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>

Applied, thanks.