From: Antonio Quartulli <ordex@autistici.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: batman-adv merge-conflict
Date: Fri, 19 Apr 2013 10:26:51 +0200 [thread overview]
Message-ID: <20130419082651.GA13226@ritirata.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]
Hi David,
here are the instructions to resolve the conflicts you will get while merging
net into net-next.
In net/batman-adv/routing.c
++<<<<<<< HEAD
+static int batadv_check_unicast_packet(struct sk_buff *skb, int hdr_size)
++=======
+ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv,
+ struct sk_buff *skb, int hdr_size)
++>>>>>>> maint
Resolves as:
/**
* batadv_check_unicast_packet - Check for malformed unicast packets
* @skb: packet to check
* @hdr_size: size of header to pull
*
* Check for short header and bad addresses in given packet. Returns negative
* value when check fails and 0 otherwise. The negative value depends on the
* reason: -ENODATA for bad header, -EBADR for broadcast destination or source,
* and -EREMOTE for non-local (other host) destination.
*/
static int batadv_check_unicast_packet(struct batadv_priv *bat_priv,
struct sk_buff *skb, int hdr_size)
===============================================================================
++<<<<<<< HEAD
+ if (!batadv_is_my_mac(ethhdr->h_dest))
+ return -EREMOTE;
++=======
+ if (!batadv_is_my_mac(bat_priv, ethhdr->h_dest))
+ return -1;
++>>>>>>> maint
Resolves as:
if (!batadv_is_my_mac(bat_priv, ethhdr->h_dest))
return -EREMOTE;
===============================================================================
++<<<<<<< HEAD
+ /* function returns -EREMOTE for promiscuous packets */
+ check = batadv_check_unicast_packet(skb, hdr_size);
+
+ /* Even though the packet is not for us, we might save it to use for
+ * decoding a later received coded packet
+ */
+ if (check == -EREMOTE)
+ batadv_nc_skb_store_sniffed_unicast(bat_priv, skb);
+
+ if (check < 0)
++=======
+ if (batadv_check_unicast_packet(bat_priv, skb, hdr_size) < 0)
++>>>>>>> maint
Resolves as:
/* function returns -EREMOTE for promiscuous packets */
check = batadv_check_unicast_packet(bat_priv, skb, hdr_size);
/* Even though the packet is not for us, we might save it to use for
* decoding a later received coded packet
*/
if (check == -EREMOTE)
batadv_nc_skb_store_sniffed_unicast(bat_priv, skb);
if (check < 0)
===============================================================================
I'm now going to send a pull request to fix some compile issues generated by the
merge.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2013-04-19 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 8:26 Antonio Quartulli [this message]
2013-04-23 0:40 ` batman-adv merge-conflict David Miller
2013-04-23 4:49 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130419082651.GA13226@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).