* [PATCH net] irda: irlmp_reasons[] can be static
[not found] <5171ea81.dFNn973/RcdmuuQR%fengguang.wu@intel.com>
@ 2013-04-20 3:10 ` Fengguang Wu
2013-04-20 11:11 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Fengguang Wu @ 2013-04-20 3:10 UTC (permalink / raw)
To: David S. Miller; +Cc: Dan Carpenter, netdev
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
irlmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
index 1064621..98ad6ec 100644
--- a/net/irda/irlmp.c
+++ b/net/irda/irlmp.c
@@ -58,7 +58,7 @@ int sysctl_discovery_slots = 6; /* 6 slots by default */
int sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
char sysctl_devname[65];
-const char *irlmp_reasons[] = {
+static const char *irlmp_reasons[] = {
"ERROR, NOT USED",
"LM_USER_REQUEST",
"LM_LAP_DISCONNECT",
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] irda: irlmp_reasons[] can be static
2013-04-20 3:10 ` [PATCH net] irda: irlmp_reasons[] can be static Fengguang Wu
@ 2013-04-20 11:11 ` Dan Carpenter
2013-04-25 5:43 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-04-20 11:11 UTC (permalink / raw)
To: Fengguang Wu; +Cc: David S. Miller, netdev
On Sat, Apr 20, 2013 at 11:10:45AM +0800, Fengguang Wu wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> irlmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
> index 1064621..98ad6ec 100644
> --- a/net/irda/irlmp.c
> +++ b/net/irda/irlmp.c
> @@ -58,7 +58,7 @@ int sysctl_discovery_slots = 6; /* 6 slots by default */
> int sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
> char sysctl_devname[65];
>
> -const char *irlmp_reasons[] = {
> +static const char *irlmp_reasons[] = {
Oops. Sorry for that. I do run Sparse on my patches but I missed
that.
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] irda: irlmp_reasons[] can be static
2013-04-20 11:11 ` Dan Carpenter
@ 2013-04-25 5:43 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-04-25 5:43 UTC (permalink / raw)
To: dan.carpenter; +Cc: fengguang.wu, netdev
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sat, 20 Apr 2013 14:11:51 +0300
> On Sat, Apr 20, 2013 at 11:10:45AM +0800, Fengguang Wu wrote:
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>> irlmp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
>> index 1064621..98ad6ec 100644
>> --- a/net/irda/irlmp.c
>> +++ b/net/irda/irlmp.c
>> @@ -58,7 +58,7 @@ int sysctl_discovery_slots = 6; /* 6 slots by default */
>> int sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
>> char sysctl_devname[65];
>>
>> -const char *irlmp_reasons[] = {
>> +static const char *irlmp_reasons[] = {
>
> Oops. Sorry for that. I do run Sparse on my patches but I missed
> that.
>
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to net-next, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-25 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5171ea81.dFNn973/RcdmuuQR%fengguang.wu@intel.com>
2013-04-20 3:10 ` [PATCH net] irda: irlmp_reasons[] can be static Fengguang Wu
2013-04-20 11:11 ` Dan Carpenter
2013-04-25 5:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).