From: Andi Kleen <andi@firstfloor.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
netdev@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] e1000: limit udelay for phy changes to 10000us
Date: Sun, 21 Apr 2013 16:27:13 +0200 [thread overview]
Message-ID: <20130421142713.GU16732@two.firstfloor.org> (raw)
In-Reply-To: <1366515285.2209.17.camel@jtkirshe-mobl>
On Sat, Apr 20, 2013 at 08:34:45PM -0700, Jeff Kirsher wrote:
> On Sat, 2013-04-20 at 20:31 -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > If you really want 100000us you should really use mdelay or so.
> >
> > Found by the LTO kernel build
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > ---
> > drivers/net/ethernet/intel/igb/e1000_phy.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Thanks Andi, I will add the patch to my igb queue. Do you want me to
> fix up the patch title as well? :-) (s/e1000/igb/)
Sure please fix.
BTW I'm not sure my fix/value is right. If you really need 100000us you need
some other mechanism to wait.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2013-04-21 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 3:31 [PATCH] e1000: limit udelay for phy changes to 10000us Andi Kleen
2013-04-21 3:34 ` Jeff Kirsher
2013-04-21 14:27 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421142713.GU16732@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).