From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: avoid inet dependency on aes crypto
Date: Mon, 22 Apr 2013 15:25:31 -0400 (EDT) [thread overview]
Message-ID: <20130422.152531.1248159074404804010.davem@davemloft.net> (raw)
In-Reply-To: <1366637403-11212-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Mon, 22 Apr 2013 15:30:03 +0200
> commit 798b2cbf9227b1bd7d37ae9af4d9c750e6f4de9c
> (net: Add INET dependency on aes crypto for the sake of TCP fastopen.)
> results in aes-asm module no longer being loaded when AES cipher is
> requested, due to CRYPTO_AES=y.
>
> However, there is no link-time dependency on aes. Drop dep and instead
> set "default m" for aes crypto if inet is enabled.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
This is terrible on so many levels.
If the assembler versions of the AES module can't be loaded properly
when AES is built statically into the kernel, don't work around it,
fix it instead.
next prev parent reply other threads:[~2013-04-22 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:30 [PATCH -next] net: avoid inet dependency on aes crypto Florian Westphal
2013-04-22 19:25 ` David Miller [this message]
2013-04-22 19:50 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422.152531.1248159074404804010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).