From: David Miller <davem@davemloft.net>
To: gang.chen@asianux.com
Cc: pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon
Date: Mon, 22 Apr 2013 15:44:23 -0400 (EDT) [thread overview]
Message-ID: <20130422.154423.1695741341535269869.davem@davemloft.net> (raw)
In-Reply-To: <51750E31.2010906@asianux.com>
From: Chen Gang <gang.chen@asianux.com>
Date: Mon, 22 Apr 2013 18:17:21 +0800
> need remove erroneous semicolon.
>
> the related commit number: c54419321455631079c7d6e60bc732dd0c5914c5
>
> Find it by EXTRA_CFLAGS=-W
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
First, what is a "type issue", you aren't changing any variable
or declaration types in this change.
Second, your formatting of your commit messages is terrible.
Do not indent the description with two spaces, just keep them at the
leftmost column. Where did you learn to indent things like that, who
else does that? If you've never seen it before, don't invent things.
It is very irritating when we see people write commit messages with
their own style rather than mimicking what other successful
contributors are doing.
Thanks.
next prev parent reply other threads:[~2013-04-22 19:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 10:17 [PATCH] Net-next: ipv4: type issue, remove erroneous semicolon Chen Gang
2013-04-22 14:32 ` Sergei Shtylyov
2013-04-23 1:12 ` Chen Gang
2013-04-23 2:45 ` [PATCH v2] Net-next: ipv4: typo " Chen Gang
2013-04-23 5:16 ` David Miller
2013-04-23 6:35 ` Chen Gang
2013-04-23 6:45 ` [PATCH net-next v3] net: " Chen Gang
2013-04-24 18:09 ` Pravin Shelar
2013-04-25 1:20 ` Chen Gang
2013-04-25 8:08 ` David Miller
2013-04-25 8:15 ` Chen Gang
2013-04-22 19:44 ` David Miller [this message]
2013-04-23 1:46 ` [PATCH] Net-next: ipv4: type " Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422.154423.1695741341535269869.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).