From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: usb: active URB submitted multiple times Date: Thu, 25 Apr 2013 01:27:46 -0400 (EDT) Message-ID: <20130425.012746.827018439951615849.davem@davemloft.net> References: <20130412.151824.2029469075886743722.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: petkan@nucleusys.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:48087 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983Ab3DYF1s (ORCPT ); Thu, 25 Apr 2013 01:27:48 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Petko Manolov Date: Fri, 19 Apr 2013 11:21:49 +0300 (EEST) > From: Petko Manolov > > (For inclusion in 3.10, diff against latest net-next.) > > Pegasus driver used single callback for sync and async control URBs. > Special flags were employed to distinguish between both, but due to flawed > logic (as Sarah Sharp spotted) it didn't always work. As a result of this > change [get|set]_registers() are now much simpler. Async write is also > leaner and does not use single, statically allocated memory for > usb_ctrlrequest, which is another potential race when asynchronously > submitting URBs. > > The socket buffer pool for the receive path is now gone. It's existence > didn't make much difference (performance-wise) and the code is better off > without the spinlocks protecting it. > > Largely duplicated code in routines reading and writing MII registers is > now packed in __mii_op(). > > Adding URL for the public pegasus git repository. > > Signed-off-by: Petko Manolov Three completely unrelated changes combined into one patch, split this up properly into three distinct changes, and resubmit them as a series with a "[PATCH 0/N]" initial posting.