* [PATCH net] gianfar: do not advertise any alarm capability.
@ 2013-04-23 5:42 Richard Cochran
2013-04-25 5:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Richard Cochran @ 2013-04-23 5:42 UTC (permalink / raw)
To: netdev; +Cc: David Miller, stable
An early draft of the PHC patch series included an alarm in the
gianfar driver. During the review process, the alarm code was dropped,
but the capability removal was overlooked. This patch fixes the issue
by advertising zero alarms.
This patch should be applied to every 3.x stable kernel.
Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Reported-by: Chris LaRocque <clarocq@gmail.com>
Cc: <stable@vger.kernel.org>
---
drivers/net/ethernet/freescale/gianfar_ptp.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar_ptp.c b/drivers/net/ethernet/freescale/gianfar_ptp.c
index 2e5daee..a3f8a25 100644
--- a/drivers/net/ethernet/freescale/gianfar_ptp.c
+++ b/drivers/net/ethernet/freescale/gianfar_ptp.c
@@ -127,7 +127,6 @@ struct gianfar_ptp_registers {
#define DRIVER "gianfar_ptp"
#define DEFAULT_CKSEL 1
-#define N_ALARM 1 /* first alarm is used internally to reset fipers */
#define N_EXT_TS 2
#define REG_SIZE sizeof(struct gianfar_ptp_registers)
@@ -410,7 +409,7 @@ static struct ptp_clock_info ptp_gianfar_caps = {
.owner = THIS_MODULE,
.name = "gianfar clock",
.max_adj = 512000,
- .n_alarm = N_ALARM,
+ .n_alarm = 0,
.n_ext_ts = N_EXT_TS,
.n_per_out = 0,
.pps = 1,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] gianfar: do not advertise any alarm capability.
2013-04-23 5:42 [PATCH net] gianfar: do not advertise any alarm capability Richard Cochran
@ 2013-04-25 5:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-04-25 5:46 UTC (permalink / raw)
To: richardcochran; +Cc: netdev, stable
From: Richard Cochran <richardcochran@gmail.com>
Date: Tue, 23 Apr 2013 07:42:16 +0200
> An early draft of the PHC patch series included an alarm in the
> gianfar driver. During the review process, the alarm code was dropped,
> but the capability removal was overlooked. This patch fixes the issue
> by advertising zero alarms.
>
> This patch should be applied to every 3.x stable kernel.
>
> Signed-off-by: Richard Cochran <richardcochran@gmail.com>
> Reported-by: Chris LaRocque <clarocq@gmail.com>
> Cc: <stable@vger.kernel.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-25 5:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-23 5:42 [PATCH net] gianfar: do not advertise any alarm capability Richard Cochran
2013-04-25 5:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).