* [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter
@ 2013-04-25 22:07 Alexander Duyck
2013-04-25 23:17 ` Stephen Hemminger
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Alexander Duyck @ 2013-04-25 22:07 UTC (permalink / raw)
To: shemminger; +Cc: netdev, Or Gerlitz, jeffrey.t.kirsher
This change corrects a kernel incompatibility that was resulting in the
ext_filter_mask not being correctly discovered by the kernel as it is buried
somewhere in the ifinfomsg.
Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
lib/libnetlink.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/libnetlink.c b/lib/libnetlink.c
index 04201cd..b17e1aa 100644
--- a/lib/libnetlink.c
+++ b/lib/libnetlink.c
@@ -99,7 +99,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
{
struct {
struct nlmsghdr nlh;
- struct rtgenmsg g;
+ struct ifinfomsg ifm;
/* attribute has to be NLMSG aligned */
struct rtattr ext_req __attribute__ ((aligned(NLMSG_ALIGNTO)));
__u32 ext_filter_mask;
@@ -111,7 +111,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
req.nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST;
req.nlh.nlmsg_pid = 0;
req.nlh.nlmsg_seq = rth->dump = ++rth->seq;
- req.g.rtgen_family = family;
+ req.ifm.ifi_family = family;
req.ext_req.rta_type = IFLA_EXT_MASK;
req.ext_req.rta_len = RTA_LENGTH(sizeof(__u32));
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter
2013-04-25 22:07 [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter Alexander Duyck
@ 2013-04-25 23:17 ` Stephen Hemminger
2013-04-25 23:22 ` David Miller
2013-05-02 14:12 ` Or Gerlitz
2013-05-02 14:13 ` Or Gerlitz
2 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2013-04-25 23:17 UTC (permalink / raw)
To: Alexander Duyck; +Cc: shemminger, netdev, Or Gerlitz, jeffrey.t.kirsher
On Thu, 25 Apr 2013 15:07:10 -0700
Alexander Duyck <alexander.h.duyck@intel.com> wrote:
> This change corrects a kernel incompatibility that was resulting in the
> ext_filter_mask not being correctly discovered by the kernel as it is buried
> somewhere in the ifinfomsg.
>
> Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
This looks good, I will apply it unless there are objections.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter
2013-04-25 23:17 ` Stephen Hemminger
@ 2013-04-25 23:22 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2013-04-25 23:22 UTC (permalink / raw)
To: stephen; +Cc: alexander.h.duyck, shemminger, netdev, ogerlitz,
jeffrey.t.kirsher
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 25 Apr 2013 16:17:03 -0700
> On Thu, 25 Apr 2013 15:07:10 -0700
> Alexander Duyck <alexander.h.duyck@intel.com> wrote:
>
>> This change corrects a kernel incompatibility that was resulting in the
>> ext_filter_mask not being correctly discovered by the kernel as it is buried
>> somewhere in the ifinfomsg.
>>
>> Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This looks good, I will apply it unless there are objections.
Same here:
Acked-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter
2013-04-25 22:07 [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter Alexander Duyck
2013-04-25 23:17 ` Stephen Hemminger
@ 2013-05-02 14:12 ` Or Gerlitz
2013-05-02 14:13 ` Or Gerlitz
2 siblings, 0 replies; 5+ messages in thread
From: Or Gerlitz @ 2013-05-02 14:12 UTC (permalink / raw)
To: Alexander Duyck; +Cc: shemminger, netdev, jeffrey.t.kirsher
On 26/04/2013 01:07, Alexander Duyck wrote:
> This change corrects a kernel incompatibility that was resulting in the
> ext_filter_mask not being correctly discovered by the kernel as it is buried
> somewhere in the ifinfomsg.
working well, thanks for fixing this up Alex.
Or.
>
> Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> lib/libnetlink.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 04201cd..b17e1aa 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -99,7 +99,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
> {
> struct {
> struct nlmsghdr nlh;
> - struct rtgenmsg g;
> + struct ifinfomsg ifm;
> /* attribute has to be NLMSG aligned */
> struct rtattr ext_req __attribute__ ((aligned(NLMSG_ALIGNTO)));
> __u32 ext_filter_mask;
> @@ -111,7 +111,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
> req.nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST;
> req.nlh.nlmsg_pid = 0;
> req.nlh.nlmsg_seq = rth->dump = ++rth->seq;
> - req.g.rtgen_family = family;
> + req.ifm.ifi_family = family;
>
> req.ext_req.rta_type = IFLA_EXT_MASK;
> req.ext_req.rta_len = RTA_LENGTH(sizeof(__u32));
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter
2013-04-25 22:07 [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter Alexander Duyck
2013-04-25 23:17 ` Stephen Hemminger
2013-05-02 14:12 ` Or Gerlitz
@ 2013-05-02 14:13 ` Or Gerlitz
2 siblings, 0 replies; 5+ messages in thread
From: Or Gerlitz @ 2013-05-02 14:13 UTC (permalink / raw)
To: Alexander Duyck; +Cc: shemminger, netdev, jeffrey.t.kirsher
On 26/04/2013 01:07, Alexander Duyck wrote:
> This change corrects a kernel incompatibility that was resulting in the
> ext_filter_mask not being correctly discovered by the kernel as it is buried
> somewhere in the ifinfomsg.
working well, thanks for fixing this upAlex.
Or.
>
> Reported-by: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> lib/libnetlink.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 04201cd..b17e1aa 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -99,7 +99,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
> {
> struct {
> struct nlmsghdr nlh;
> - struct rtgenmsg g;
> + struct ifinfomsg ifm;
> /* attribute has to be NLMSG aligned */
> struct rtattr ext_req __attribute__ ((aligned(NLMSG_ALIGNTO)));
> __u32 ext_filter_mask;
> @@ -111,7 +111,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
> req.nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST;
> req.nlh.nlmsg_pid = 0;
> req.nlh.nlmsg_seq = rth->dump = ++rth->seq;
> - req.g.rtgen_family = family;
> + req.ifm.ifi_family = family;
>
> req.ext_req.rta_type = IFLA_EXT_MASK;
> req.ext_req.rta_len = RTA_LENGTH(sizeof(__u32));
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-02 14:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-25 22:07 [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req_filter Alexander Duyck
2013-04-25 23:17 ` Stephen Hemminger
2013-04-25 23:22 ` David Miller
2013-05-02 14:12 ` Or Gerlitz
2013-05-02 14:13 ` Or Gerlitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).