From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Frank Li <lznuaa@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Frank Li <Frank.Li@freescale.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call"
Date: Fri, 26 Apr 2013 15:44:15 +0200 [thread overview]
Message-ID: <20130426134415.GS1366@pengutronix.de> (raw)
In-Reply-To: <CAHrpEqQLkjCOq0doaM0zNMkgjNkE_pOLxjoFJWNPuQ6CRHCbBw@mail.gmail.com>
Frank,
On Fri, Apr 26, 2013 at 05:32:02PM +0800, Frank Li wrote:
> 2013/4/26 Lucas Stach <l.stach@pengutronix.de>:
> > This reverts commit 3f104c38259dcb3e5443c246f0805bc04d887cc3.
> >
> > In preparaton to revert the other NAPI related changes.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> David:
>
> Please hold apply this patch for some days.
> Let me found a good way to fix the issue that lucas met.
>
> This patch may cause spin_lock dead lock when using 1588 ptp.
Seriously - it's friday, and 3.9 is expected to come out this weekend.
You broke the driver in mainline with your patches, and the current
state is that it isn't fixable before the release.
So in order not to break the FEC in 3.9-final, please let's go with the
reverts for now; if 1588 PTP is broken, it was broken in 3.8 as well,
correct? After the release, there will be a lot of time to make proper
patches that fix the issues.
rsc
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-04-26 13:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 8:52 [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 2/3] Revert "net: fec: put tx to napi poll function to fix dead lock" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 3/3] Revert "net: fec: add napi support to improve proformance" Lucas Stach
2013-04-26 9:32 ` [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Frank Li
2013-04-26 13:44 ` Robert Schwebel [this message]
2013-04-26 18:33 ` David Miller
2013-04-27 9:05 ` Robert Schwebel
2013-04-27 10:26 ` Frank Li
2013-04-27 12:06 ` Francois Romieu
2013-04-27 12:43 ` Frank Li
2013-04-27 19:16 ` Francois Romieu
2013-04-28 3:09 ` Frank Li
2013-04-28 4:31 ` Frank Li
2013-04-28 9:40 ` Francois Romieu
2013-04-28 10:03 ` Frank Li
2013-04-28 9:39 ` Francois Romieu
2013-04-28 10:05 ` Frank Li
2013-04-28 17:57 ` Francois Romieu
2013-04-28 23:45 ` Frank Li
2013-04-29 13:46 ` Lucas Stach
2013-05-02 1:51 ` Frank Li
2013-04-28 5:11 ` David Miller
2013-04-28 17:27 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426134415.GS1366@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).