From: Robert Schwebel <r.schwebel@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: r.schwebel@pengutronix.de, lznuaa@gmail.com,
l.stach@pengutronix.de, netdev@vger.kernel.org,
Frank.Li@freescale.com, festevam@gmail.com, shawn.guo@linaro.org
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call"
Date: Sat, 27 Apr 2013 11:05:45 +0200 [thread overview]
Message-ID: <20130427090545.GY1366@pengutronix.de> (raw)
In-Reply-To: <20130426.143309.1011152996477262852.davem@davemloft.net>
On Fri, Apr 26, 2013 at 02:33:09PM -0400, David Miller wrote:
> From: Robert Schwebel <r.schwebel@pengutronix.de>
> Date: Fri, 26 Apr 2013 15:44:15 +0200
>
> > Seriously - it's friday, and 3.9 is expected to come out this
> > weekend.
>
> Seriously, it took you how long to notice the breakage and report
> it in sufficient detail for the author to make an attempt at a fix?
>
> I thnk Frank's request is reasonable given the circumstances, please
> work closely with him on the fix.
The FEC driver has worked fine in 3.8.x.
Frank's patches for the 3.9 cycle...
- remove locking in a way that memory is freed which is in use
- break the driver, up to a point where the kernel oopses when the link
goes away
- mix up different changes (queue handling) and should have been split up
into separate patches
Unfortunately, the breakage happens only on multicore (MX6Q) and if you
change the link status; that's probably the reason why it hasn't been
noticed earlier.
We have really tried to find a "quick fix which does it right", but it
has turned out that this isn't possible in such a short time, because it
is more complex than just re-adding locks. We feel that the results of
last week's activities are not good enough that they could be merged
without further breakage.
Please consider to merge the reverts. Otherwhise FEC will be broken in 3.9.
Of course, we can help with a real solution, but please after 3.9.final.
Thanks,
Robert
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-04-27 9:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 8:52 [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 2/3] Revert "net: fec: put tx to napi poll function to fix dead lock" Lucas Stach
2013-04-26 8:52 ` [PATCH resend 3/3] Revert "net: fec: add napi support to improve proformance" Lucas Stach
2013-04-26 9:32 ` [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call" Frank Li
2013-04-26 13:44 ` Robert Schwebel
2013-04-26 18:33 ` David Miller
2013-04-27 9:05 ` Robert Schwebel [this message]
2013-04-27 10:26 ` Frank Li
2013-04-27 12:06 ` Francois Romieu
2013-04-27 12:43 ` Frank Li
2013-04-27 19:16 ` Francois Romieu
2013-04-28 3:09 ` Frank Li
2013-04-28 4:31 ` Frank Li
2013-04-28 9:40 ` Francois Romieu
2013-04-28 10:03 ` Frank Li
2013-04-28 9:39 ` Francois Romieu
2013-04-28 10:05 ` Frank Li
2013-04-28 17:57 ` Francois Romieu
2013-04-28 23:45 ` Frank Li
2013-04-29 13:46 ` Lucas Stach
2013-05-02 1:51 ` Frank Li
2013-04-28 5:11 ` David Miller
2013-04-28 17:27 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130427090545.GY1366@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).