netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gang.chen@asianux.com
Cc: dborkman@redhat.com, c.aeschlimann@acn-group.ch,
	sergei.shtylyov@cogentembedded.com,
	alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
	linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH v5] net: mac802154: comparision issue of type cast, finding by EXTRA_CFLAGS=-W
Date: Mon, 29 Apr 2013 12:29:34 -0400 (EDT)	[thread overview]
Message-ID: <20130429.122934.2073602835665028801.davem@davemloft.net> (raw)
In-Reply-To: <51790A53.8040107@asianux.com>

From: Chen Gang <gang.chen@asianux.com>
Date: Thu, 25 Apr 2013 18:49:55 +0800

> 
> Change MAC802154_CHAN_NONE from ~(u8)0 to 0xff, or the comparison in
> mac802154_wpan_xmit() for ``chan == MAC802154_CHAN_NONE'' will not
> succeed.
> 
> This bug can be boiled down to ``u8 foo = 0xff; if (foo == ~(u8)0)
> [...] else [...]'' where the condition will always take the else
> branch. 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Applied, thanks.

  reply	other threads:[~2013-04-29 16:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22  6:41 [PATCH] Net: mac802154: comparing issue by type cast, finding by EXTRA_CFLAGS=-W Chen Gang
2013-04-22 14:09 ` Sergei Shtylyov
2013-04-23  1:11   ` Chen Gang
2013-04-23  2:54     ` [PATCH v2] Net: mac802154: comparision issue of " Chen Gang
2013-04-23 11:22       ` Chen Gang
2013-04-23 11:24       ` [PATCH v3] net: " Chen Gang
2013-04-25  8:10         ` David Miller
2013-04-25  8:43           ` Chen Gang
2013-04-25  9:01             ` David Miller
2013-04-25  9:09               ` Chen Gang
     [not found]             ` <5178ECA2.6020402-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-04-25  9:02               ` Christophe Aeschlimann
2013-04-25  9:06                 ` Chen Gang
2013-04-25  9:40                 ` [PATCH v4] " Chen Gang
2013-04-25  9:59                   ` Daniel Borkmann
2013-04-25 10:44                     ` Chen Gang
2013-04-25 10:49                     ` [PATCH v5] " Chen Gang
2013-04-29 16:29                       ` David Miller [this message]
2013-05-02  1:11                         ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429.122934.2073602835665028801.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alex.bluesman.smirnov@gmail.com \
    --cc=c.aeschlimann@acn-group.ch \
    --cc=dbaryshkov@gmail.com \
    --cc=dborkman@redhat.com \
    --cc=gang.chen@asianux.com \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).