From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 2/3] unix/dgram: fix peeking with an offset larger than data in queue Date: Tue, 30 Apr 2013 00:44:13 -0400 (EDT) Message-ID: <20130430.004413.138604814207380591.davem@davemloft.net> References: <1367271734-14379-1-git-send-email-bpoirier@suse.de> <1367271734-14379-2-git-send-email-bpoirier@suse.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: edumazet@google.com, xemul@parallels.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: bpoirier@suse.de Return-path: In-Reply-To: <1367271734-14379-2-git-send-email-bpoirier@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Benjamin Poirier Date: Mon, 29 Apr 2013 17:42:13 -0400 > Currently, peeking on a unix datagram socket with an offset larger than len of > the data in the sk receive queue returns immediately with bogus data. That's > because *off is not reset between each skb_queue_walk(). > > This patch fixes this so that the behavior is the same as peeking with no > offset on an empty queue: the caller blocks. > > Signed-off-by: Benjamin Poirier Applied.