From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: somnath.kotur@emulex.com, netdev@vger.kernel.org,
kalesh.purayil@emulex.com
Subject: Re: [PATCH net 2/4] be2net: Fix ethtool get drvinfo
Date: Tue, 30 Apr 2013 15:52:01 -0400 (EDT) [thread overview]
Message-ID: <20130430.155201.2039547623230450224.davem@davemloft.net> (raw)
In-Reply-To: <1367328131.5106.62.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 30 Apr 2013 14:22:11 +0100
> On Tue, 2013-04-30 at 17:07 +0530, Somnath Kotur wrote:
>> From: Kalesh AP <kalesh.purayil@emulex.com>
>>
>> Cannot issue any other mailbox command while firmware download is in progress.
>> The get_drvinfo ethtool hook can be invoked without acquiring any rtnl_lock.
> [...]
>
> Although I documented that as being possible in ethtool.h, that was only
> because of one particular caller that has since been removed (commit
> e52ac3398c3d 'net: Use device model to get driver name in
> skb_gso_segment()'). So unless I missed another case, you could change
> the documentation.
Please address Ben's feedback and resubmit this series, thanks.
next prev parent reply other threads:[~2013-04-30 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 11:37 [PATCH net 2/4] be2net: Fix ethtool get drvinfo Somnath Kotur
2013-04-30 13:22 ` Ben Hutchings
2013-04-30 19:52 ` David Miller [this message]
2013-05-02 13:32 ` Kotur, Somnath
2013-05-07 6:27 ` Kotur, Somnath
2013-05-07 15:21 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430.155201.2039547623230450224.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=kalesh.purayil@emulex.com \
--cc=netdev@vger.kernel.org \
--cc=somnath.kotur@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).