* [BUG] ipv6 and TSO on GRE is broken
@ 2013-05-01 15:53 Eric Dumazet
2013-05-02 7:02 ` Pravin Shelar
0 siblings, 1 reply; 6+ messages in thread
From: Eric Dumazet @ 2013-05-01 15:53 UTC (permalink / raw)
To: netdev; +Cc: Pravin B Shelar, Steinar H. Gunderson
This was reported by Steinar.
Sending this to netdev, as I wont have time to debug this in the near
future. (~ 3 days)
3.9 and latest net-next are broken for IPv6 on top of GRE tunnel
GSO seems OK, but TSO not :
lpq83:~# ethtool -K gre1 tso off gso on
lpq83:~# netperf -H 4444::555:0084
MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
() port 0 AF_INET6
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
87380 16384 16384 10.00 3789.10
lpq83:~# ethtool -K gre1 tso on
lpq83:~# netperf -H 4444::555:0084
MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
() port 0 AF_INET6
Recv Send Send
Socket Socket Message Elapsed
Size Size Size Time Throughput
bytes bytes bytes secs. 10^6bits/sec
87380 16384 16384 10.00 321.27
No problem for IPv4
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] ipv6 and TSO on GRE is broken
2013-05-01 15:53 [BUG] ipv6 and TSO on GRE is broken Eric Dumazet
@ 2013-05-02 7:02 ` Pravin Shelar
2013-05-02 8:00 ` Pravin Shelar
0 siblings, 1 reply; 6+ messages in thread
From: Pravin Shelar @ 2013-05-02 7:02 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, Steinar H. Gunderson
I forgot to add gre gso handler to inet6 offloads list.
I will send out patch soon.
Thanks,
Pravin.
On Wed, May 1, 2013 at 8:53 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> This was reported by Steinar.
>
> Sending this to netdev, as I wont have time to debug this in the near
> future. (~ 3 days)
>
> 3.9 and latest net-next are broken for IPv6 on top of GRE tunnel
>
> GSO seems OK, but TSO not :
>
> lpq83:~# ethtool -K gre1 tso off gso on
> lpq83:~# netperf -H 4444::555:0084
> MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
> () port 0 AF_INET6
> Recv Send Send
> Socket Socket Message Elapsed
> Size Size Size Time Throughput
> bytes bytes bytes secs. 10^6bits/sec
>
> 87380 16384 16384 10.00 3789.10
> lpq83:~# ethtool -K gre1 tso on
> lpq83:~# netperf -H 4444::555:0084
> MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
> () port 0 AF_INET6
> Recv Send Send
> Socket Socket Message Elapsed
> Size Size Size Time Throughput
> bytes bytes bytes secs. 10^6bits/sec
>
> 87380 16384 16384 10.00 321.27
>
>
> No problem for IPv4
>
> Thanks
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] ipv6 and TSO on GRE is broken
2013-05-02 7:02 ` Pravin Shelar
@ 2013-05-02 8:00 ` Pravin Shelar
2013-05-02 8:32 ` Berge Schwebs Bjørlo
0 siblings, 1 reply; 6+ messages in thread
From: Pravin Shelar @ 2013-05-02 8:00 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, Steinar H. Gunderson
On Thu, May 2, 2013 at 12:02 AM, Pravin Shelar <pshelar@nicira.com> wrote:
> I forgot to add gre gso handler to inet6 offloads list.
>
> I will send out patch soon.
>
nevermind, I guess you were talking abt ipv6 over gre-ipv4 device, I
will check the code.
> Thanks,
> Pravin.
>
> On Wed, May 1, 2013 at 8:53 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> This was reported by Steinar.
>>
>> Sending this to netdev, as I wont have time to debug this in the near
>> future. (~ 3 days)
>>
>> 3.9 and latest net-next are broken for IPv6 on top of GRE tunnel
>>
>> GSO seems OK, but TSO not :
>>
>> lpq83:~# ethtool -K gre1 tso off gso on
>> lpq83:~# netperf -H 4444::555:0084
>> MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
>> () port 0 AF_INET6
>> Recv Send Send
>> Socket Socket Message Elapsed
>> Size Size Size Time Throughput
>> bytes bytes bytes secs. 10^6bits/sec
>>
>> 87380 16384 16384 10.00 3789.10
>> lpq83:~# ethtool -K gre1 tso on
>> lpq83:~# netperf -H 4444::555:0084
>> MIGRATED TCP STREAM TEST from ::0 (::) port 0 AF_INET6 to 4444::555:0084
>> () port 0 AF_INET6
>> Recv Send Send
>> Socket Socket Message Elapsed
>> Size Size Size Time Throughput
>> bytes bytes bytes secs. 10^6bits/sec
>>
>> 87380 16384 16384 10.00 321.27
>>
>>
>> No problem for IPv4
>>
>> Thanks
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] ipv6 and TSO on GRE is broken
2013-05-02 8:00 ` Pravin Shelar
@ 2013-05-02 8:32 ` Berge Schwebs Bjørlo
2013-05-03 2:17 ` Pravin Shelar
0 siblings, 1 reply; 6+ messages in thread
From: Berge Schwebs Bjørlo @ 2013-05-02 8:32 UTC (permalink / raw)
To: Pravin Shelar; +Cc: Eric Dumazet, netdev, Steinar H. Gunderson
On Thu, May 02, 2013 at 01:00:54AM -0700, Pravin Shelar wrote:
> On Thu, May 2, 2013 at 12:02 AM, Pravin Shelar <pshelar@nicira.com> wrote:
>> I forgot to add gre gso handler to inet6 offloads list.
>>
>> I will send out patch soon.
> nevermind, I guess you were talking abt ipv6 over gre-ipv4 device, I will
> check the code.
I'm not sure if we're talking about the same issue, but I'm experiencing
massive packet drops with outbound IPv6 traffic with a GREv4 tunnel with IPv6
traffic on the inside. Inbound traffic seems fine, and IPv4 inside the tunnel
is fine in both directions.
First observed when upgrading to 3.9 the other day. 3.8 was fine. git bisect
and a kernel-recompile-reboot-dance points to commit
68c331631143f5f039baac99a650e0b9e1ea02b6 as the culprit.
Cheers,
-Berge
--
Berge Schwebs Bjørlo
Alegría!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] ipv6 and TSO on GRE is broken
2013-05-02 8:32 ` Berge Schwebs Bjørlo
@ 2013-05-03 2:17 ` Pravin Shelar
2013-05-03 14:52 ` Berge Schwebs Bjørlo
0 siblings, 1 reply; 6+ messages in thread
From: Pravin Shelar @ 2013-05-03 2:17 UTC (permalink / raw)
To: Berge Schwebs Bjørlo; +Cc: Eric Dumazet, netdev, Steinar H. Gunderson
On Thu, May 2, 2013 at 1:32 AM, Berge Schwebs Bjørlo <berge@trivini.no> wrote:
> On Thu, May 02, 2013 at 01:00:54AM -0700, Pravin Shelar wrote:
>> On Thu, May 2, 2013 at 12:02 AM, Pravin Shelar <pshelar@nicira.com> wrote:
>>> I forgot to add gre gso handler to inet6 offloads list.
>>>
>>> I will send out patch soon.
>> nevermind, I guess you were talking abt ipv6 over gre-ipv4 device, I will
>> check the code.
>
> I'm not sure if we're talking about the same issue, but I'm experiencing
> massive packet drops with outbound IPv6 traffic with a GREv4 tunnel with IPv6
> traffic on the inside. Inbound traffic seems fine, and IPv4 inside the tunnel
> is fine in both directions.
>
> First observed when upgrading to 3.9 the other day. 3.8 was fine. git bisect
> and a kernel-recompile-reboot-dance points to commit
> 68c331631143f5f039baac99a650e0b9e1ea02b6 as the culprit.
>
Thanks,
I posted fix on netdev.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [BUG] ipv6 and TSO on GRE is broken
2013-05-03 2:17 ` Pravin Shelar
@ 2013-05-03 14:52 ` Berge Schwebs Bjørlo
0 siblings, 0 replies; 6+ messages in thread
From: Berge Schwebs Bjørlo @ 2013-05-03 14:52 UTC (permalink / raw)
To: Pravin Shelar; +Cc: Eric Dumazet, netdev, Steinar H. Gunderson
On Thu, May 02, 2013 at 07:17:57PM -0700, Pravin Shelar wrote:
> On Thu, May 2, 2013 at 1:32 AM, Berge Schwebs Bjørlo <berge@trivini.no>
> wrote:
>> I'm not sure if we're talking about the same issue, but I'm experiencing
>> massive packet drops with outbound IPv6 traffic with a GREv4 tunnel with
>> IPv6 traffic on the inside. Inbound traffic seems fine, and IPv4 inside
>> the tunnel is fine in both directions.
> I posted fix on netdev.
The patch fixes my issues. Thanks!
-B
--
Berge Schwebs Bjørlo
Alegría!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-03 14:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-01 15:53 [BUG] ipv6 and TSO on GRE is broken Eric Dumazet
2013-05-02 7:02 ` Pravin Shelar
2013-05-02 8:00 ` Pravin Shelar
2013-05-02 8:32 ` Berge Schwebs Bjørlo
2013-05-03 2:17 ` Pravin Shelar
2013-05-03 14:52 ` Berge Schwebs Bjørlo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).