* [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence
@ 2013-05-02 11:52 Mugunthan V N
2013-05-02 12:37 ` Sebastian Andrzej Siewior
2013-05-02 20:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Mugunthan V N @ 2013-05-02 11:52 UTC (permalink / raw)
To: netdev; +Cc: davem, linux-omap, Mugunthan V N, Sebastian Siewior
In CPSW NAPI, after processing all interrupts IRQ is enabled and then book
keeping irq_enabled is updated. In random cases when a packet is transmitted
or received between processing packets and IRQ enabled, then just after
enabled IRQ and before irq_enabled is updated, ISR is called so IRQs are
not disabled as irq_enabled is still false and CPU gets locked in CPSW ISR.
By changing the sequence as update the irq_enabled and then enable IRQ
fixes the issue. This issue is not captured always as it is a timing issue
whether Tx or Rx IRQ is invoked between packet processing and enable IRQ.
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
---
drivers/net/ethernet/ti/cpsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 59c4391..21a5b29 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -555,8 +555,8 @@ static int cpsw_poll(struct napi_struct *napi, int budget)
cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_RX);
prim_cpsw = cpsw_get_slave_priv(priv, 0);
if (prim_cpsw->irq_enabled == false) {
- cpsw_enable_irq(priv);
prim_cpsw->irq_enabled = true;
+ cpsw_enable_irq(priv);
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence
2013-05-02 11:52 [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence Mugunthan V N
@ 2013-05-02 12:37 ` Sebastian Andrzej Siewior
2013-05-02 20:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-05-02 12:37 UTC (permalink / raw)
To: Mugunthan V N; +Cc: netdev, davem, linux-omap
* Mugunthan V N | 2013-05-02 17:22:11 [+0530]:
>In CPSW NAPI, after processing all interrupts IRQ is enabled and then book
>keeping irq_enabled is updated. In random cases when a packet is transmitted
>or received between processing packets and IRQ enabled, then just after
>enabled IRQ and before irq_enabled is updated, ISR is called so IRQs are
>not disabled as irq_enabled is still false and CPU gets locked in CPSW ISR.
>
>By changing the sequence as update the irq_enabled and then enable IRQ
>fixes the issue. This issue is not captured always as it is a timing issue
>whether Tx or Rx IRQ is invoked between packet processing and enable IRQ.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence
2013-05-02 11:52 [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence Mugunthan V N
2013-05-02 12:37 ` Sebastian Andrzej Siewior
@ 2013-05-02 20:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-02 20:52 UTC (permalink / raw)
To: mugunthanvnm; +Cc: netdev, linux-omap, bigeasy
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Thu, 2 May 2013 17:22:11 +0530
> In CPSW NAPI, after processing all interrupts IRQ is enabled and then book
> keeping irq_enabled is updated. In random cases when a packet is transmitted
> or received between processing packets and IRQ enabled, then just after
> enabled IRQ and before irq_enabled is updated, ISR is called so IRQs are
> not disabled as irq_enabled is still false and CPU gets locked in CPSW ISR.
>
> By changing the sequence as update the irq_enabled and then enable IRQ
> fixes the issue. This issue is not captured always as it is a timing issue
> whether Tx or Rx IRQ is invoked between packet processing and enable IRQ.
>
> Cc: Sebastian Siewior <bigeasy@linutronix.de>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-02 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 11:52 [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence Mugunthan V N
2013-05-02 12:37 ` Sebastian Andrzej Siewior
2013-05-02 20:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).