From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] bridge: fix race with topology change timer
Date: Fri, 03 May 2013 16:11:37 -0400 (EDT) [thread overview]
Message-ID: <20130503.161137.1979947914410869390.davem@davemloft.net> (raw)
In-Reply-To: <20130502172328.2ff0273f@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 2 May 2013 17:23:28 -0700
> A bridge should only send topology change notice if it is not
> the root bridge. It is possible for message age timer to elect itself
> as a new root bridge, and still have a topology change timer running
> but waiting for bridge lock on other CPU.
>
> Solve the race by checking if we are root bridge before continuing.
> This was the root cause of the cases where br_send_tcn_bpdu would OOPS.
>
> Reported-by: JerryKang <jerry.kang@samsung.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied and queued up for -stable.
prev parent reply other threads:[~2013-05-03 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 0:23 [PATCH net] bridge: fix race with topology change timer Stephen Hemminger
2013-05-03 20:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503.161137.1979947914410869390.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).