* [PATCH] virtio: don't expose u16 in userspace api
@ 2013-05-04 0:49 Stephen Hemminger
2013-05-05 20:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2013-05-04 0:49 UTC (permalink / raw)
To: David Miller, Jason Wang; +Cc: linux-kernel, netdev, Amos Kong
Programs using virtio headers outside of kernel will no longer
build because u16 type does not exist in userspace. All user ABI
must use __u16 typedef instead.
Bug introduce by:
commit 986a4f4d452dec004697f667439d27c3fda9c928
Author: Jason Wang <jasowang@redhat.com>
Date: Fri Dec 7 07:04:56 2012 +0000
virtio_net: multiqueue support
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
Patch against -net but should go to stable for 3.9.1
--- a/include/uapi/linux/virtio_net.h 2013-05-02 14:30:53.362557982 -0700
+++ b/include/uapi/linux/virtio_net.h 2013-05-03 17:44:06.028365521 -0700
@@ -191,7 +191,7 @@ struct virtio_net_ctrl_mac {
* specified.
*/
struct virtio_net_ctrl_mq {
- u16 virtqueue_pairs;
+ __u16 virtqueue_pairs;
};
#define VIRTIO_NET_CTRL_MQ 4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio: don't expose u16 in userspace api
2013-05-04 0:49 [PATCH] virtio: don't expose u16 in userspace api Stephen Hemminger
@ 2013-05-05 20:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-05 20:58 UTC (permalink / raw)
To: stephen; +Cc: jasowang, linux-kernel, netdev, akong
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 3 May 2013 17:49:41 -0700
> Programs using virtio headers outside of kernel will no longer
> build because u16 type does not exist in userspace. All user ABI
> must use __u16 typedef instead.
>
> Bug introduce by:
> commit 986a4f4d452dec004697f667439d27c3fda9c928
> Author: Jason Wang <jasowang@redhat.com>
> Date: Fri Dec 7 07:04:56 2012 +0000
>
> virtio_net: multiqueue support
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-05 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 0:49 [PATCH] virtio: don't expose u16 in userspace api Stephen Hemminger
2013-05-05 20:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).