* [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface
@ 2013-05-06 9:16 Schemmel Hans-Christoph
2013-05-06 12:07 ` Bjørn Mork
2013-05-06 14:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Schemmel Hans-Christoph @ 2013-05-06 9:16 UTC (permalink / raw)
To: netdev@vger.kernel.org; +Cc: linux-kernel@vger.kernel.org
/drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
---
patch is against linux-3.9
--- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
+++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
@@ -569,6 +569,7 @@ static const struct usb_device_id produc
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface
2013-05-06 9:16 [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface Schemmel Hans-Christoph
@ 2013-05-06 12:07 ` Bjørn Mork
2013-05-06 14:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bjørn Mork @ 2013-05-06 12:07 UTC (permalink / raw)
To: Schemmel Hans-Christoph
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com> writes:
> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
> ---
> patch is against linux-3.9
> --- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
> +++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
> @@ -569,6 +569,7 @@ static const struct usb_device_id produc
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
> + {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Looks good. Thanks.
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface
2013-05-06 9:16 [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface Schemmel Hans-Christoph
2013-05-06 12:07 ` Bjørn Mork
@ 2013-05-06 14:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-06 14:26 UTC (permalink / raw)
To: Hans-Christoph.Schemmel; +Cc: netdev, linux-kernel
From: Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com>
Date: Mon, 6 May 2013 11:16:46 +0200
> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
The Subject needs to use lowercase letters for the "prefix: " bit
coming after "[PATCH]" and use a more appropropate area indication.
"qmi_wwan: " would have been more appropriate.
Also, properly text format your commit messages so that lines are no longer
than 80 columns.
Just because it looks like it's properly formatted on your computer screen
doesn't mean it is.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-06 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 9:16 [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface Schemmel Hans-Christoph
2013-05-06 12:07 ` Bjørn Mork
2013-05-06 14:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).