* [patch -next] netpoll: inverted down_trylock() test
@ 2013-05-06 12:15 Dan Carpenter
2013-05-06 13:00 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-05-06 12:15 UTC (permalink / raw)
To: David S. Miller, Neil Horman
Cc: Cong Wang, Eric Dumazet, Jiri Pirko, netdev, kernel-janitors
The return value is reversed from mutex_trylock().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index a5802a8..cec074b 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -206,7 +206,7 @@ static void netpoll_poll_dev(struct net_device *dev)
* the dev_open/close paths use this to block netpoll activity
* while changing device state
*/
- if (!down_trylock(&ni->dev_lock))
+ if (down_trylock(&ni->dev_lock))
return;
if (!netif_running(dev)) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch -next] netpoll: inverted down_trylock() test
2013-05-06 12:15 [patch -next] netpoll: inverted down_trylock() test Dan Carpenter
@ 2013-05-06 13:00 ` Dan Carpenter
2013-05-06 15:08 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-05-06 13:00 UTC (permalink / raw)
To: David S. Miller, Neil Horman
Cc: Cong Wang, Eric Dumazet, Jiri Pirko, netdev, kernel-janitors
This is needed in mainline actually. I typed -next by mistake.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch -next] netpoll: inverted down_trylock() test
2013-05-06 13:00 ` Dan Carpenter
@ 2013-05-06 15:08 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-05-06 15:08 UTC (permalink / raw)
To: dan.carpenter; +Cc: nhorman, amwang, edumazet, jiri, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 6 May 2013 16:00:24 +0300
> This is needed in mainline actually. I typed -next by mistake.
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-06 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 12:15 [patch -next] netpoll: inverted down_trylock() test Dan Carpenter
2013-05-06 13:00 ` Dan Carpenter
2013-05-06 15:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).