From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v3 5/7] ARM: kirkwood: remove legacy mv643xx_eth board setup Date: Mon, 6 May 2013 17:39:09 +0200 Message-ID: <20130506173909.10dc7c59@skate> References: <1365071235-11611-1-git-send-email-florian@openwrt.org> <1367854420-8006-1-git-send-email-sebastian.hesselbarth@gmail.com> <1367854420-8006-6-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jamie Lentin , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nigel Roberts , Arnaud Patard , Valentin Longchamp , Russell King , Simon Guinot , Grant Likely , Lennert Buytenhek , Eric Hutter , Jason Cooper , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Arnaud Ebalard , Rob Herring , Joshua Coombs , Florian Fainelli , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jean-Francois Moine , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alan M Butler , Willy Tarreau , David Miller To: Sebastian Hesselbarth Return-path: In-Reply-To: <1367854420-8006-6-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" List-Id: netdev.vger.kernel.org Dear Sebastian Hesselbarth, On Mon, 6 May 2013 17:33:38 +0200, Sebastian Hesselbarth wrote: > With DT support for mv643xx_eth we do not need legacy platform_data > based setup for DT enabled boards. This patch removes eth setup > for all kirkwood DT board files. > > arch/arm/mach-kirkwood/board-dnskw.c | 7 ------- > arch/arm/mach-kirkwood/board-dockstar.c | 9 --------- > arch/arm/mach-kirkwood/board-dreamplug.c | 14 -------------- > arch/arm/mach-kirkwood/board-goflexnet.c | 9 --------- > arch/arm/mach-kirkwood/board-guruplug.c | 14 -------------- > arch/arm/mach-kirkwood/board-ib62x0.c | 9 --------- > arch/arm/mach-kirkwood/board-iconnect.c | 6 ------ > arch/arm/mach-kirkwood/board-iomega_ix2_200.c | 16 ---------------- > arch/arm/mach-kirkwood/board-km_kirkwood.c | 7 ------- > arch/arm/mach-kirkwood/board-lsxl.c | 12 ------------ > arch/arm/mach-kirkwood/board-mplcec4.c | 11 ----------- > arch/arm/mach-kirkwood/board-ns2.c | 13 ------------- > arch/arm/mach-kirkwood/board-openblocks_a6.c | 9 --------- > arch/arm/mach-kirkwood/board-readynas.c | 6 ------ > arch/arm/mach-kirkwood/board-ts219.c | 13 ------------- > arch/arm/mach-kirkwood/board-usi_topkick.c | 9 --------- I believe a good number of those files become empty once you've removed the registration of the Ethernet devices. Shouldn't such files be removed in this patch? Thanks! Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com