From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 1/2] freezer: add unsafe versions of freezable helpers Date: Mon, 6 May 2013 15:14:20 -0700 Message-ID: <20130506221420.GH800@mtj.dyndns.org> References: <1367615050-3894-1-git-send-email-ccross@android.com> <20130506065605.6e5ed5e2@tlielax.poochiereds.net> <20130506174336.447d0d75@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Colin Cross , Jeff Layton , lkml , Trond Myklebust , Len Brown , Pavel Machek , "Rafael J. Wysocki" , Peter Zijlstra , Ingo Molnar , "J. Bruce Fields" , "David S. Miller" , Andrew Morton , Mandeep Singh Baines , Paul Walmsley , Al Viro , "Eric W. Biederman" , Oleg Nesterov , linux-nfs , Linux PM list , netdev , Ben Chan , Steve French To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello, Linus. On Mon, May 06, 2013 at 02:58:31PM -0700, Linus Torvalds wrote: > Quite frankly, is it worth resurrecting these patches at all? > > The only things it actually complained about are not worth the pain > fixing and are getting explicitly not warned about - is there any > reason to believe the patches are worth maintaining and the extra > complexity is worth it? It might not be too useful for nfs but Colin has a patchset spreading the use of the freezable schedules in a number of places in an attempt to reduce freeze latency for android, which includes introducing a lot of schedule_*_freezable() constructs, so I think we need these warnings one way or the other so that we don't end up with more problems like nfs currently has. Thakns. -- tejun