From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: [RFC PATCH net-next] sh_eth: add support for r8a7790 SoC
Date: Mon, 13 May 2013 09:36:50 +0900
Message-ID: <20130513003648.GA22911@verge.net.au>
References: <1368172891-26381-1-git-send-email-horms+renesas@verge.net.au>
 <518CD330.5030009@cogentembedded.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Return-path: <linux-sh-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <518CD330.5030009@cogentembedded.com>
Sender: linux-sh-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Fri, May 10, 2013 at 03:00:00PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 10-05-2013 12:01, Simon Horman wrote:
> 
> >Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> [...]
> 
> >diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> >index 33dc6f2..1ec26bd 100644
> >--- a/drivers/net/ethernet/renesas/sh_eth.c
> >+++ b/drivers/net/ethernet/renesas/sh_eth.c
> [...]
> >@@ -342,7 +343,8 @@ static void sh_eth_select_mii(struct net_device *ndev)
> >  #endif
> >
> >  /* There is CPU dependent code */
> >-#if defined(CONFIG_ARCH_R8A7778) || defined(CONFIG_ARCH_R8A7779)
> >+#if defined(CONFIG_ARCH_R8A7778) || defined(CONFIG_ARCH_R8A7779) || \
> >+	defined(CONFIG_ARCH_R8A7790)
> >  #define SH_ETH_RESET_DEFAULT	1
> >  static void sh_eth_set_duplex(struct net_device *ndev)
> >  {
> >@@ -370,7 +372,7 @@ static void sh_eth_set_rate(struct net_device *ndev)
> >  	}
> >  }
> >
> >-/* R8A7778/9 */
> >+/* R8A7778, R8A7779, R8A7790 */
> >  static struct sh_eth_cpu_data sh_eth_my_cpu_data = {
> >  	.set_duplex	= sh_eth_set_duplex,
> >  	.set_rate	= sh_eth_set_rate,
> >@@ -1275,6 +1277,10 @@ static int sh_eth_dev_init(struct net_device *ndev, bool start)
> >  	if (ret)
> >  		goto out;
> >
> >+#if defined(CONFIG_ARCH_R8A7790)
> >+	sh_eth_write(ndev, 0x1, RMIIMODE);
> >+#endif
> >+
> 
>    Ugh, this #ifdef will be hard to get rid of. Perhaps you should
> add a field to 'struct sh_eth_cpu_data' indicating the presence of
> this register instead.

Sure, I'll see about making that so.