From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, mischnal@google.com, bbeck@google.com
Subject: Re: [PATCH] tcp: fix tcp_md5_hash_skb_data()
Date: Tue, 14 May 2013 11:33:12 -0700 (PDT) [thread overview]
Message-ID: <20130514.113312.1004832430857949707.davem@davemloft.net> (raw)
In-Reply-To: <1368516352.32106.13.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 14 May 2013 00:25:52 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> TCP md5 communications fail [1] for some devices, because sg/crypto code
> assume page offsets are below PAGE_SIZE.
>
> This was discovered using mlx4 driver [2], but I suspect loopback
> might trigger the same bug now we use order-3 pages in tcp_sendmsg()
>
> [1] Failure is giving following messages.
>
> huh, entered softirq 3 NET_RX ffffffff806ad230 preempt_count 00000100,
> exited with 00000101?
>
> [2] mlx4 driver uses order-2 pages to allocate RX frags
>
> Reported-by: Matt Schnall <mischnal@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2013-05-14 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 7:25 [PATCH] tcp: fix tcp_md5_hash_skb_data() Eric Dumazet
2013-05-14 17:58 ` Eric Dumazet
2013-05-14 18:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514.113312.1004832430857949707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bbeck@google.com \
--cc=eric.dumazet@gmail.com \
--cc=mischnal@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox