From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] vxlan: force user to set port value Date: Wed, 15 May 2013 15:04:33 -0700 Message-ID: <20130515150433.1eb4c73a@nehalam.linuxnetplumber.net> References: <20130515095322.275c9b2f@nehalam.linuxnetplumber.net> <20130515.132213.120685330795916926.davem@davemloft.net> <20130515134818.18b2c710@nehalam.linuxnetplumber.net> <20130515.144730.888918410336115705.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dlstevens@us.ibm.com, amwang@redhat.com, netdev@vger.kernel.org, netdev-owner@vger.kernel.org To: David Miller Return-path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:49082 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141Ab3EOWEh (ORCPT ); Wed, 15 May 2013 18:04:37 -0400 Received: by mail-pa0-f48.google.com with SMTP id kp6so1893753pab.21 for ; Wed, 15 May 2013 15:04:37 -0700 (PDT) In-Reply-To: <20130515.144730.888918410336115705.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 15 May 2013 14:47:30 -0700 (PDT) David Miller wrote: > > Stephen, this doesn't work either. > > You're breaking people's scripts. > > Even worse, you're breaking things, and your error message doesn't > even tell the user how to get the previous behavior. You're telling > them how to get new behavior, which they probably don't give a > crap about. They want their existing stuff to work. > > Stop being in denial, we are stuck with the old port number default. > > Again, we cannot change this default without breaking something which > we've already deployed to users. > > If this port number issue was so important, we should have done > something about it when we integrated vxlan. But we didn't, so we > have to live with the consequences. > > Now is far too late to change the default. So you want RHEL customers to continue to use the pre-standard Cisco port in their clouds and be incompatible with standards? I made a mistake in the initial implementation using that value and every user for time immemorial has to suffer. Since every distro patches iproute anyway, let them keep the non-standard compatibility if that is what they demand.