From: Stephen Hemminger <stephen@networkplumber.org>
To: Cong Wang <amwang@redhat.com>
Cc: David Stevens <dlstevens@us.ibm.com>,
netdev@vger.kernel.org, netdev-owner@vger.kernel.org
Subject: Re: [RFT] vxlan: listen on multiple ports
Date: Wed, 15 May 2013 23:20:58 -0700 [thread overview]
Message-ID: <20130515232058.46ef3135@samsung-9> (raw)
In-Reply-To: <1368672673.12751.19.camel@cr0>
On Thu, 16 May 2013 10:51:13 +0800
Cong Wang <amwang@redhat.com> wrote:
> On Wed, 2013-05-15 at 14:37 -0700, Stephen Hemminger wrote:
> > The earlier change to introduce per-vxlan UDP port configuration did only
> > half the necessary work. It added per vxlan destination for sending, but
> > overlooked the handling of multiple ports for incoming, which means it
> > is broken.
> >
> > This patch changes the listening port management to handle multiple
> > incoming UDP ports. The earlier per-namespace structure is now a hash
> > list per namespace.
> >
> > It is also now possible to define the same virtual network id
> > but with different UDP port values.
> >
>
> Besides fixing the default port issue, what other benefits does it have?
> This seems overkill.
>
> It looks like you make one socket per port, after my IPv6 patches, we
> would have two sockets per port...
>
>
The destination port option is broken now. It only sets the port
for outgoing packets, it does not change port used for incoming packets.
This change is to address that. Sorry, it shouldn't be a big
impact for IPv6.
next prev parent reply other threads:[~2013-05-16 6:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 11:11 [Patch iproute2] vxlan: use 8472 as default dst port Cong Wang
2013-05-15 11:32 ` David Stevens
2013-05-15 16:53 ` Stephen Hemminger
2013-05-15 17:19 ` David Stevens
2013-05-15 17:43 ` Stephen Hemminger
2013-05-15 18:11 ` David Stevens
2013-05-16 8:24 ` David Laight
2013-05-16 16:02 ` Stephen Hemminger
2013-05-15 20:23 ` David Miller
2013-05-15 17:48 ` Stephen Hemminger
2013-05-15 18:42 ` David Stevens
2013-05-15 21:37 ` [RFT] vxlan: listen on multiple ports Stephen Hemminger
2013-05-16 2:51 ` Cong Wang
2013-05-16 6:20 ` Stephen Hemminger [this message]
2013-05-15 20:22 ` [Patch iproute2] vxlan: use 8472 as default dst port David Miller
2013-05-15 20:25 ` Stephen Hemminger
2013-05-15 20:48 ` [PATCH] vxlan: force user to set port value Stephen Hemminger
2013-05-15 21:47 ` David Miller
2013-05-15 22:04 ` Stephen Hemminger
2013-05-15 22:40 ` David Miller
2013-05-15 22:19 ` Stephen Hemminger
2013-05-15 21:57 ` Sridhar Samudrala
2013-05-15 22:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130515232058.46ef3135@samsung-9 \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=dlstevens@us.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).