Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, maze@google.com, therbert@google.com,
	ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH] tcp: gso: do not generate out of order packets
Date: Thu, 16 May 2013 14:44:02 -0700 (PDT)	[thread overview]
Message-ID: <20130516.144402.851927775820198853.davem@davemloft.net> (raw)
In-Reply-To: <1368668281.4519.75.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 15 May 2013 18:38:01 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> GSO TCP handler has following issues :
> 
> 1) ooo_okay from original GSO packet is duplicated to all segments
> 2) segments (but the last one) are orphaned, so transmit path can not
> get transmit queue number from the socket. This happens if GSO
> segmentation is done before stacked device for example.
> 
> Result is we can send packets from a given TCP flow to different TX
> queues (if using multiqueue NICS). This generates OOO problems and
> spurious SACK & retransmits.
> 
> Fix this by keeping socket pointer set for all segments.
> 
> This means that every segment must also have a destructor, and the
> original gso skb truesize must be split on all segments, to keep
> precise sk->sk_wmem_alloc accounting.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.

      parent reply	other threads:[~2013-05-16 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  1:38 [PATCH] tcp: gso: do not generate out of order packets Eric Dumazet
2013-05-16  3:58 ` Maciej Żenczykowski
2013-05-16  4:19   ` Eric Dumazet
2013-05-16  4:46   ` Eric Dumazet
2013-05-16 21:44 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516.144402.851927775820198853.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=maze@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox