From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: "Bjørn Mork" <bjorn@mork.no>,
netdev@vger.kernel.org,
"Fedora Kernel Team" <kernel-team@fedoraproject.org>
Subject: Re: net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility
Date: Thu, 16 May 2013 14:25:10 -0400 [thread overview]
Message-ID: <20130516182510.GA4728@redhat.com> (raw)
Hi Bjørn,
> Gitweb: http://git.kernel.org/linus/;a=commit;h=1e8bbe6cd02fc300c88bd48244ce61ad9c7d1776
> Commit: 1e8bbe6cd02fc300c88bd48244ce61ad9c7d1776
> Parent: a5b8db91442fce9c9713fcd656c3698f1adde1d6
> Author: Bjørn Mork <bjorn@mork.no>
> AuthorDate: Thu Mar 14 01:05:13 2013 +0000
> Committer: David S. Miller <davem@davemloft.net>
> CommitDate: Sun Mar 17 11:59:03 2013 -0400
>
> net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility
>
> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> introduced a new policy, preferring MBIM for dual NCM/MBIM functions if
> the cdc_mbim driver was enabled. This caused a regression for users
> wanting to use NCM.
>
> Devices implementing NCM backwards compatibility according to section
> 3.2 of the MBIM v1.0 specification allow either NCM or MBIM on a single
> USB function, using different altsettings. The cdc_ncm and cdc_mbim
> drivers will both probe such functions, and must agree on a common
> policy for selecting either MBIM or NCM. Until now, this policy has
> been set at build time based on CONFIG_USB_NET_CDC_MBIM.
>
> Use a module parameter to set the system policy at runtime, allowing the
> user to prefer NCM on systems with the cdc_mbim driver.
Is there any way we can set this automatically based on the type of device connected
and have it just work without users needing to edit modprobe.conf ?
Since this change, we've now getting reports like https://bugzilla.redhat.com/show_bug.cgi?id=963663
Dave
next reply other threads:[~2013-05-16 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 18:25 Dave Jones [this message]
2013-05-16 19:08 ` net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility Bjørn Mork
2013-05-16 19:17 ` Dave Jones
2013-05-16 19:23 ` Bjørn Mork
2013-05-16 19:35 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516182510.GA4728@redhat.com \
--to=davej@redhat.com \
--cc=bjorn@mork.no \
--cc=kernel-team@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).