From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, dborkman@redhat.com
Subject: Re: [PATCH net-next] filter: do not output bpf image address for security reason
Date: Fri, 17 May 2013 18:27:21 -0700 (PDT) [thread overview]
Message-ID: <20130517.182721.470869310914541917.davem@davemloft.net> (raw)
In-Reply-To: <1368839478.3469.70.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 18 May 2013 02:11:18 +0100
> On Fri, 2013-05-17 at 16:31 -0700, Eric Dumazet wrote:
>> @@ -58,10 +58,11 @@ extern void bpf_jit_free(struct sk_filter *fp);
>> static inline void bpf_jit_dump(unsigned int flen, unsigned int proglen,
>> u32 pass, void *image)
>> {
>> - pr_err("flen=%u proglen=%u pass=%u image=%p\n",
>> - flen, proglen, pass, image);
>> + /* Do not output address (image) for security reason */
>> + pr_err("flen=%u proglen=%u pass=%u image=10\n",
>
> Not "%pK"?
Yes, that's the acceptable way to deal with this issue.
next prev parent reply other threads:[~2013-05-18 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 23:31 [PATCH net-next] filter: do not output bpf image address for security reason Eric Dumazet
2013-05-17 23:42 ` Joe Perches
2013-05-17 23:48 ` Eric Dumazet
2013-05-18 1:11 ` Ben Hutchings
2013-05-18 1:27 ` David Miller [this message]
2013-05-18 2:55 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2013-05-18 2:57 Eric Dumazet
2013-05-20 6:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517.182721.470869310914541917.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox