From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org, hayeswang@realtek.com,
stefan.bader@canonical.com, holger.hoffstaette@googlemail.com,
sergei.shtylyov@cogentembedded.com, ben@decadent.org.uk
Subject: Re: [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets.
Date: Mon, 20 May 2013 00:01:49 -0700 (PDT) [thread overview]
Message-ID: <20130520.000149.840626794135761237.davem@davemloft.net> (raw)
In-Reply-To: <20130518112446.GA21268@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Sat, 18 May 2013 13:24:46 +0200
> 8168evl offloaded checksums are wrong since commit
> e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.")
> pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
> appear as UDP checksums which are wrong by the count of added bytes.
>
> It isn't worth compensating. Let the driver checksum.
>
> Due to the skb length changes, TSO code is moved before the Tx descriptor gets
> written.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>
> I reworked some code since v1 to avoid wtf effects in the future. Holger's
> Tested-by is thus not included. While I trust my testing, it would be nice
> to wait for his ack as well.
>
> This is obviously stuff for -stable.
Applied and queued up for -stable, thanks!
prev parent reply other threads:[~2013-05-20 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 11:24 [PATCH v2 net 1/1] r8169: fix offloaded tx checksum for small packets Francois Romieu
2013-05-18 14:42 ` Holger Hoffstätte
2013-06-10 11:12 ` Holger Hoffstätte
2013-06-10 21:54 ` Francois Romieu
2013-05-20 7:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520.000149.840626794135761237.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=hayeswang@realtek.com \
--cc=holger.hoffstaette@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).