From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next] net-bnx2x: dont reload on GRO change
Date: Mon, 20 May 2013 00:17:03 -0700 (PDT) [thread overview]
Message-ID: <20130520.001703.3222910244436114.davem@davemloft.net> (raw)
In-Reply-To: <504C9EFCA2D0054393414C9CB605C37F20C5054D@SJEXCHMB06.corp.ad.broadcom.com>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Sat, 18 May 2013 21:36:07 +0000
>> -----Original Message-----
>> From: Eric Dumazet [mailto:eric.dumazet@gmail.com]
>> Sent: Saturday, May 18, 2013 8:15 PM
>> To: David Miller
>> Cc: netdev; Dmitry Kravkov; Eilon Greenstein
>> Subject: [PATCH net-next] net-bnx2x: dont reload on GRO change
>>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> bnx2x_set_features() forces a driver reload if GRO setting is changed.
>>
>> A reload makes the ethernet port unresponsive for about 5 seconds.
>>
>> This is not needed in the common case LRO is enabled, as LRO
>> (TPA_ENABLE_FLAG) has precedence over GRO (GRO_ENABLE_FLAG)
>>
>> Tested:
>> Verified that "ethtool -K eth0 gro {on|off}" doesn't blackout
>> the NIC anymore
>>
>> Google-Bug-Id: 8440442
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
...
> Looks good! Thanks, Eric
>
> Acked-by: Dmitry Kravkov <dmitry@broadcom.com>
>
Applied, thanks.
prev parent reply other threads:[~2013-05-20 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 17:14 [PATCH net-next] net-bnx2x: dont reload on GRO change Eric Dumazet
2013-05-18 21:36 ` Dmitry Kravkov
2013-05-20 7:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520.001703.3222910244436114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox