From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next] arp: flush arp cache on IFF_NOARP change
Date: Mon, 20 May 2013 13:46:33 -0700 (PDT) [thread overview]
Message-ID: <20130520.134633.448574202175922639.davem@davemloft.net> (raw)
In-Reply-To: <1369056541-4523-1-git-send-email-timo.teras@iki.fi>
From: Timo Teräs <timo.teras@iki.fi>
Date: Mon, 20 May 2013 16:29:01 +0300
> IFF_NOARP affects what kind of neighbor entries are created
> (nud NOARP or nud INCOMPLETE). If the flag changes, flush the arp
> cache to refresh all entries.
>
> Signed-off-by: Timo Teräs <timo.teras@iki.fi>
> Cc: Patrick McHardy <kaber@trash.net>
This patch makes no sense at all.
The state bit in ->priv_flags is a boolean stating whether the
notified should do something or not.
But you're setting it to match what IFF_NOARP is.
You should set it any time IFF_NOARP _changes_, and then clear
the bit when the notifier clears the neighbour entries.
next prev parent reply other threads:[~2013-05-20 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 13:29 [PATCH net-next] arp: flush arp cache on IFF_NOARP change Timo Teräs
2013-05-20 20:46 ` David Miller [this message]
2013-05-21 10:23 ` [PATCH v2 " Timo Teräs
2013-05-21 16:25 ` Ben Hutchings
2013-05-21 18:29 ` Timo Teras
2013-05-21 18:54 ` Ben Hutchings
2013-05-23 7:01 ` David Miller
2013-05-23 7:49 ` Timo Teras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520.134633.448574202175922639.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).